#!/usr/bin/env python2 # -*- coding: utf-8 -*- import unittest import mock import os import sys sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..")) from pungi.phases.buildinstall import BuildinstallPhase, BuildinstallThread from tests.helpers import DummyCompose, PungiTestCase class BuildInstallCompose(DummyCompose): def __init__(self, *args, **kwargs): super(BuildInstallCompose, self).__init__(*args, **kwargs) self.variants = { 'Server': mock.Mock(uid='Server', arches=['x86_64', 'amd64'], type='variant', buildinstallpackages=['bash', 'vim'], is_empty=False), 'Client': mock.Mock(uid='Client', arches=['amd64'], type='variant', buildinstallpackages=[], is_empty=False), } class TestBuildinstallPhase(PungiTestCase): def test_config_skip_unless_bootable(self): compose = BuildInstallCompose(self.topdir, {}) compose.just_phases = None compose.skip_phases = [] phase = BuildinstallPhase(compose) self.assertTrue(phase.skip()) def test_does_not_skip_on_bootable(self): compose = BuildInstallCompose(self.topdir, {'bootable': True}) compose.just_phases = None compose.skip_phases = [] phase = BuildinstallPhase(compose) self.assertFalse(phase.skip()) @mock.patch('pungi.phases.buildinstall.ThreadPool') @mock.patch('pungi.phases.buildinstall.LoraxWrapper') @mock.patch('pungi.phases.buildinstall.get_volid') def test_starts_threads_for_each_cmd_with_lorax(self, get_volid, loraxCls, poolCls): compose = BuildInstallCompose(self.topdir, { 'bootable': True, 'release_name': 'Test', 'release_short': 't', 'release_version': '1', 'release_is_layered': False, 'buildinstall_method': 'lorax' }) get_volid.return_value = 'vol_id' phase = BuildinstallPhase(compose) phase.run() # Three items added for processing in total. # Server.x86_64, Client.amd64, Server.x86_64 pool = poolCls.return_value self.assertEqual(3, len(pool.queue_put.mock_calls)) # Obtained correct lorax commands. self.assertItemsEqual( loraxCls.return_value.get_lorax_cmd.mock_calls, [mock.call('Test', '1', '1', self.topdir + '/work/x86_64/repo', self.topdir + '/work/x86_64/buildinstall/Server', buildarch='x86_64', is_final=True, nomacboot=True, noupgrade=True, volid='vol_id', variant='Server', buildinstallpackages=['bash', 'vim'], bugurl=None), mock.call('Test', '1', '1', self.topdir + '/work/amd64/repo', self.topdir + '/work/amd64/buildinstall/Server', buildarch='amd64', is_final=True, nomacboot=True, noupgrade=True, volid='vol_id', variant='Server', buildinstallpackages=['bash', 'vim'], bugurl=None), mock.call('Test', '1', '1', self.topdir + '/work/amd64/repo', self.topdir + '/work/amd64/buildinstall/Client', buildarch='amd64', is_final=True, nomacboot=True, noupgrade=True, volid='vol_id', variant='Client', buildinstallpackages=[], bugurl=None)]) @mock.patch('pungi.phases.buildinstall.ThreadPool') @mock.patch('pungi.phases.buildinstall.LoraxWrapper') @mock.patch('pungi.phases.buildinstall.get_volid') def test_lorax_skips_empty_variants(self, get_volid, loraxCls, poolCls): compose = BuildInstallCompose(self.topdir, { 'bootable': True, 'release_name': 'Test', 'release_short': 't', 'release_version': '1', 'release_is_layered': False, 'buildinstall_method': 'lorax' }) get_volid.return_value = 'vol_id' compose.variants['Server'].is_empty = True phase = BuildinstallPhase(compose) phase.run() pool = poolCls.return_value self.assertEqual(1, len(pool.queue_put.mock_calls)) # Obtained correct lorax command. lorax = loraxCls.return_value lorax.get_lorax_cmd.assert_has_calls( [mock.call('Test', '1', '1', self.topdir + '/work/amd64/repo', self.topdir + '/work/amd64/buildinstall/Client', buildarch='amd64', is_final=True, nomacboot=True, noupgrade=True, volid='vol_id', variant='Client', buildinstallpackages=[], bugurl=None)], any_order=True) @mock.patch('pungi.phases.buildinstall.ThreadPool') @mock.patch('pungi.phases.buildinstall.LoraxWrapper') @mock.patch('pungi.phases.buildinstall.get_volid') def test_starts_threads_for_each_cmd_with_buildinstall(self, get_volid, loraxCls, poolCls): compose = BuildInstallCompose(self.topdir, { 'bootable': True, 'release_name': 'Test', 'release_short': 't', 'release_version': '1', 'release_is_layered': False, 'buildinstall_method': 'buildinstall' }) get_volid.return_value = 'vol_id' phase = BuildinstallPhase(compose) phase.run() # Two items added for processing in total. pool = poolCls.return_value self.assertEqual(2, len(pool.queue_put.mock_calls)) # Obtained correct lorax commands. self.assertItemsEqual( loraxCls.return_value.get_buildinstall_cmd.mock_calls, [mock.call('Test', '1', '1', self.topdir + '/work/x86_64/repo', self.topdir + '/work/x86_64/buildinstall', buildarch='x86_64', is_final=True, volid='vol_id'), mock.call('Test', '1', '1', self.topdir + '/work/amd64/repo', self.topdir + '/work/amd64/buildinstall', buildarch='amd64', is_final=True, volid='vol_id')]) def test_global_upgrade_with_lorax(self): compose = BuildInstallCompose(self.topdir, { 'bootable': True, 'buildinstall_method': 'lorax', 'buildinstall_upgrade_image': True, }) phase = BuildinstallPhase(compose) with self.assertRaises(ValueError) as ctx: phase.validate() self.assertIn('Deprecated config option: buildinstall_upgrade_image', ctx.exception.message) def test_lorax_options_with_buildinstall(self): compose = BuildInstallCompose(self.topdir, { 'bootable': True, 'buildinstall_method': 'buildinstall', 'lorax_options': [], }) phase = BuildinstallPhase(compose) with self.assertRaises(ValueError) as ctx: phase.validate() self.assertIn('buildinstall', ctx.exception.message) self.assertIn('lorax_options', ctx.exception.message) @mock.patch('pungi.phases.buildinstall.ThreadPool') @mock.patch('pungi.phases.buildinstall.LoraxWrapper') @mock.patch('pungi.phases.buildinstall.get_volid') def test_uses_lorax_options(self, get_volid, loraxCls, poolCls): compose = BuildInstallCompose(self.topdir, { 'bootable': True, 'release_name': 'Test', 'release_short': 't', 'release_version': '1', 'release_is_layered': False, 'buildinstall_method': 'lorax', 'lorax_options': [ ('^Server$', { 'x86_64': {'bugurl': 'http://example.com'}, 'amd64': {'noupgrade': False} }), ('^Client$', { '*': {'nomacboot': False} }), ] }) get_volid.return_value = 'vol_id' phase = BuildinstallPhase(compose) phase.run() # Three items added for processing in total. # Server.x86_64, Client.amd64, Server.x86_64 pool = poolCls.return_value self.assertEqual(3, len(pool.queue_put.mock_calls)) # Obtained correct lorax commands. self.assertItemsEqual( loraxCls.return_value.get_lorax_cmd.mock_calls, [mock.call('Test', '1', '1', self.topdir + '/work/x86_64/repo', self.topdir + '/work/x86_64/buildinstall/Server', buildarch='x86_64', is_final=True, nomacboot=True, noupgrade=True, volid='vol_id', variant='Server', buildinstallpackages=['bash', 'vim'], bugurl='http://example.com'), mock.call('Test', '1', '1', self.topdir + '/work/amd64/repo', self.topdir + '/work/amd64/buildinstall/Server', buildarch='amd64', is_final=True, nomacboot=True, noupgrade=False, volid='vol_id', variant='Server', buildinstallpackages=['bash', 'vim'], bugurl=None), mock.call('Test', '1', '1', self.topdir + '/work/amd64/repo', self.topdir + '/work/amd64/buildinstall/Client', buildarch='amd64', is_final=True, nomacboot=False, noupgrade=True, volid='vol_id', variant='Client', buildinstallpackages=[], bugurl=None)]) @mock.patch('pungi.phases.buildinstall.ThreadPool') @mock.patch('pungi.phases.buildinstall.LoraxWrapper') @mock.patch('pungi.phases.buildinstall.get_volid') def test_multiple_lorax_options(self, get_volid, loraxCls, poolCls): compose = BuildInstallCompose(self.topdir, { 'bootable': True, 'release_name': 'Test', 'release_short': 't', 'release_version': '1', 'release_is_layered': False, 'buildinstall_method': 'lorax', 'lorax_options': [ ('^.*$', { 'x86_64': {'nomacboot': False}, '*': {'noupgrade': False} }), ] }) get_volid.return_value = 'vol_id' phase = BuildinstallPhase(compose) phase.run() # Three items added for processing in total. # Server.x86_64, Client.amd64, Server.x86_64 pool = poolCls.return_value self.assertEqual(3, len(pool.queue_put.mock_calls)) # Obtained correct lorax commands. self.assertItemsEqual( loraxCls.return_value.get_lorax_cmd.mock_calls, [mock.call('Test', '1', '1', self.topdir + '/work/x86_64/repo', self.topdir + '/work/x86_64/buildinstall/Server', buildarch='x86_64', is_final=True, nomacboot=False, noupgrade=False, volid='vol_id', variant='Server', buildinstallpackages=['bash', 'vim'], bugurl=None), mock.call('Test', '1', '1', self.topdir + '/work/amd64/repo', self.topdir + '/work/amd64/buildinstall/Server', buildarch='amd64', is_final=True, nomacboot=True, noupgrade=False, volid='vol_id', variant='Server', buildinstallpackages=['bash', 'vim'], bugurl=None), mock.call('Test', '1', '1', self.topdir + '/work/amd64/repo', self.topdir + '/work/amd64/buildinstall/Client', buildarch='amd64', is_final=True, nomacboot=True, noupgrade=False, volid='vol_id', variant='Client', buildinstallpackages=[], bugurl=None)]) class TestCopyFiles(PungiTestCase): @mock.patch('pungi.phases.buildinstall.symlink_boot_iso') @mock.patch('pungi.phases.buildinstall.tweak_buildinstall') @mock.patch('pungi.phases.buildinstall.get_volid') @mock.patch('os.listdir') @mock.patch('os.path.isdir') @mock.patch('pungi.phases.buildinstall.get_kickstart_file') def test_copy_files_buildinstall(self, get_kickstart_file, isdir, listdir, get_volid, tweak_buildinstall, symlink_boot_iso): compose = BuildInstallCompose(self.topdir, { 'buildinstall_method': 'buildinstall' }) get_volid.side_effect = ( lambda compose, arch, variant, escape_spaces, disc_type: "%s.%s" % (variant.uid, arch) ) get_kickstart_file.return_value = 'kickstart' phase = BuildinstallPhase(compose) phase.copy_files() self.assertItemsEqual( get_volid.mock_calls, [mock.call(compose, 'x86_64', compose.variants['Server'], escape_spaces=False, disc_type='boot'), mock.call(compose, 'amd64', compose.variants['Client'], escape_spaces=False, disc_type='boot'), mock.call(compose, 'amd64', compose.variants['Server'], escape_spaces=False, disc_type='boot')]) self.assertItemsEqual( tweak_buildinstall.mock_calls, [mock.call(self.topdir + '/work/x86_64/buildinstall', self.topdir + '/compose/Server/x86_64/os', 'x86_64', 'Server', '', 'Server.x86_64', 'kickstart'), mock.call(self.topdir + '/work/amd64/buildinstall', self.topdir + '/compose/Server/amd64/os', 'amd64', 'Server', '', 'Server.amd64', 'kickstart'), mock.call(self.topdir + '/work/amd64/buildinstall', self.topdir + '/compose/Client/amd64/os', 'amd64', 'Client', '', 'Client.amd64', 'kickstart')]) self.assertItemsEqual( symlink_boot_iso.mock_calls, [mock.call(compose, 'x86_64', compose.variants['Server']), mock.call(compose, 'amd64', compose.variants['Client']), mock.call(compose, 'amd64', compose.variants['Server'])]) @mock.patch('pungi.phases.buildinstall.symlink_boot_iso') @mock.patch('pungi.phases.buildinstall.tweak_buildinstall') @mock.patch('pungi.phases.buildinstall.get_volid') @mock.patch('os.listdir') @mock.patch('os.path.isdir') @mock.patch('pungi.phases.buildinstall.get_kickstart_file') def test_copy_files_lorax(self, get_kickstart_file, isdir, listdir, get_volid, tweak_buildinstall, symlink_boot_iso): compose = BuildInstallCompose(self.topdir, { 'buildinstall_method': 'lorax' }) get_volid.side_effect = ( lambda compose, arch, variant, escape_spaces, disc_type: "%s.%s" % (variant.uid, arch) ) get_kickstart_file.return_value = 'kickstart' phase = BuildinstallPhase(compose) phase.copy_files() self.assertItemsEqual( get_volid.mock_calls, [mock.call(compose, 'x86_64', compose.variants['Server'], escape_spaces=False, disc_type='boot'), mock.call(compose, 'amd64', compose.variants['Client'], escape_spaces=False, disc_type='boot'), mock.call(compose, 'amd64', compose.variants['Server'], escape_spaces=False, disc_type='boot')]) self.assertItemsEqual( tweak_buildinstall.mock_calls, [mock.call(self.topdir + '/work/x86_64/buildinstall/Server', self.topdir + '/compose/Server/x86_64/os', 'x86_64', 'Server', '', 'Server.x86_64', 'kickstart'), mock.call(self.topdir + '/work/amd64/buildinstall/Server', self.topdir + '/compose/Server/amd64/os', 'amd64', 'Server', '', 'Server.amd64', 'kickstart'), mock.call(self.topdir + '/work/amd64/buildinstall/Client', self.topdir + '/compose/Client/amd64/os', 'amd64', 'Client', '', 'Client.amd64', 'kickstart')]) self.assertItemsEqual( symlink_boot_iso.mock_calls, [mock.call(compose, 'x86_64', compose.variants['Server']), mock.call(compose, 'amd64', compose.variants['Client']), mock.call(compose, 'amd64', compose.variants['Server'])]) class BuildinstallThreadTestCase(PungiTestCase): @mock.patch('pungi.phases.buildinstall.KojiWrapper') @mock.patch('pungi.phases.buildinstall.get_buildroot_rpms') @mock.patch('pungi.phases.buildinstall.run') def test_buildinstall_thread_with_lorax_in_runroot(self, run, get_buildroot_rpms, KojiWrapperMock): compose = BuildInstallCompose(self.topdir, { 'buildinstall_method': 'lorax', 'runroot': True, 'runroot_tag': 'rrt', 'koji_profile': 'koji', }) get_buildroot_rpms.return_value = ['bash', 'zsh'] pool = mock.Mock() cmd = mock.Mock() get_runroot_cmd = KojiWrapperMock.return_value.get_runroot_cmd run_runroot_cmd = KojiWrapperMock.return_value.run_runroot_cmd run_runroot_cmd.return_value = { 'output': 'Foo bar baz', 'retcode': 0, 'task_id': 1234, } t = BuildinstallThread(pool) with mock.patch('time.sleep'): t.process((compose, 'x86_64', compose.variants['Server'], cmd), 0) self.assertItemsEqual( get_runroot_cmd.mock_calls, [mock.call('rrt', 'x86_64', cmd, channel=None, use_shell=True, task_id=True, packages=['strace', 'lorax'], mounts=[self.topdir])]) run_runroot_cmd(get_runroot_cmd.return_value, log_file='/log/buildinstall-Server.x86_64.log') with open(self.topdir + '/logs/x86_64/buildinstall-Server-RPMs.x86_64.log') as f: rpms = f.read().strip().split('\n') self.assertItemsEqual(rpms, ['bash', 'zsh']) @mock.patch('pungi.phases.buildinstall.KojiWrapper') @mock.patch('pungi.phases.buildinstall.get_buildroot_rpms') @mock.patch('pungi.phases.buildinstall.run') def test_buildinstall_thread_with_buildinstall_in_runroot(self, run, get_buildroot_rpms, KojiWrapperMock): compose = BuildInstallCompose(self.topdir, { 'buildinstall_method': 'buildinstall', 'runroot': True, 'runroot_tag': 'rrt', 'koji_profile': 'koji', }) get_buildroot_rpms.return_value = ['bash', 'zsh'] pool = mock.Mock() cmd = mock.Mock() get_runroot_cmd = KojiWrapperMock.return_value.get_runroot_cmd run_runroot_cmd = KojiWrapperMock.return_value.run_runroot_cmd run_runroot_cmd.return_value = { 'output': 'Foo bar baz', 'retcode': 0, 'task_id': 1234, } t = BuildinstallThread(pool) with mock.patch('time.sleep'): t.process((compose, 'x86_64', None, cmd), 0) self.assertItemsEqual( get_runroot_cmd.mock_calls, [mock.call('rrt', 'x86_64', cmd, channel=None, use_shell=True, task_id=True, packages=['strace', 'anaconda'], mounts=[self.topdir])]) run_runroot_cmd(get_runroot_cmd.return_value, log_file=self.topdir + '/logs/buildinstall.x86_64.log') with open(self.topdir + '/logs/x86_64/buildinstall-RPMs.x86_64.log') as f: rpms = f.read().strip().split('\n') self.assertItemsEqual(rpms, ['bash', 'zsh']) @mock.patch('pungi.phases.buildinstall.KojiWrapper') @mock.patch('pungi.phases.buildinstall.get_buildroot_rpms') @mock.patch('pungi.phases.buildinstall.run') def test_buildinstall_fail_exit_code(self, run, get_buildroot_rpms, KojiWrapperMock): compose = BuildInstallCompose(self.topdir, { 'buildinstall_method': 'buildinstall', 'runroot': True, 'runroot_tag': 'rrt', 'koji_profile': 'koji', 'failable_deliverables': [ ('^.+$', {'*': ['buildinstall']}) ], }) get_buildroot_rpms.return_value = ['bash', 'zsh'] pool = mock.Mock() cmd = mock.Mock() run_runroot_cmd = KojiWrapperMock.return_value.run_runroot_cmd run_runroot_cmd.return_value = { 'output': 'Foo bar baz', 'retcode': 1, 'task_id': 1234, } t = BuildinstallThread(pool) with mock.patch('time.sleep'): t.process((compose, 'x86_64', None, cmd), 0) pool.log_info.assert_has_calls([ mock.call('[BEGIN] Running buildinstall for arch x86_64'), mock.call('[FAIL] Buildinstall for variant None arch x86_64 failed, but going on anyway.\n' 'Runroot task failed: 1234. See %s/logs/x86_64/buildinstall.x86_64.log for more details.' % self.topdir) ]) @mock.patch('pungi.phases.buildinstall.KojiWrapper') @mock.patch('pungi.phases.buildinstall.get_buildroot_rpms') @mock.patch('pungi.phases.buildinstall.run') def test_lorax_fail_exit_code(self, run, get_buildroot_rpms, KojiWrapperMock): compose = BuildInstallCompose(self.topdir, { 'buildinstall_method': 'lorax', 'runroot': True, 'runroot_tag': 'rrt', 'koji_profile': 'koji', 'failable_deliverables': [ ('^.+$', {'*': ['buildinstall']}) ], }) get_buildroot_rpms.return_value = ['bash', 'zsh'] pool = mock.Mock() cmd = mock.Mock() run_runroot_cmd = KojiWrapperMock.return_value.run_runroot_cmd run_runroot_cmd.return_value = { 'output': 'Foo bar baz', 'retcode': 1, 'task_id': 1234, } t = BuildinstallThread(pool) with mock.patch('time.sleep'): t.process((compose, 'x86_64', compose.variants['Server'], cmd), 0) pool.log_info.assert_has_calls([ mock.call('[BEGIN] Running buildinstall for arch x86_64'), mock.call('[FAIL] Buildinstall for variant Server arch x86_64 failed, but going on anyway.\n' 'Runroot task failed: 1234. See %s/logs/x86_64/buildinstall-Server.x86_64.log for more details.' % self.topdir) ]) if __name__ == "__main__": unittest.main()