almalinux/pungi
15
2
Fork 0
Code Issues Pull Requests Releases Activity

ALBS-1030: Generate Devel section in packages.json #14

Merged
soksanichenko merged 5 commits from ALBS-1030 into al_master 2023-03-22 10:06:59 +00:00
Conversation 0 Commits 5 Files Changed 3 +153 -64
soksanichenko commented 2023-03-19 16:22:00 +00:00
Owner
Copy Link
  • Also the tool can combine (remove and add) packages in a variant from different
    sources according to an url's type of source
- Also the tool can combine (remove and add) packages in a variant from different sources according to an url's type of source
soksanichenko added 1 commit 2023-03-19 16:22:00 +00:00 
- Also the tool can combine (remove and add) packages in a variant from different
  sources according to an url's type of source
soksanichenko added 1 commit 2023-03-19 19:11:20 +00:00 
- Some upstream changes to KojiMock parts
soksanichenko added 1 commit 2023-03-20 11:25:53 +00:00 
- Skip verifying an RPM signature if sigkeys are empty
jhernandez reviewed 2023-03-20 11:38:17 +00:00
pungi/phases/pkgset/sources/source_kojimock.py Outdated
@ -190,3 +194,3 @@
latest_version = sorted_modules[0]["module_version"]
modules = [
module for module in modules if latest_version == module["module_version"]
module for module in modules if
jhernandez commented 2023-03-20 11:38:17 +00:00
Member
Copy Link

Just a personal taste for readability, I'd move if into the next line

Just a personal taste for readability, I'd move `if` into the next line
soksanichenko marked this conversation as resolved
jhernandez reviewed 2023-03-20 11:45:21 +00:00
pungi/phases/pkgset/sources/source_kojimock.py Outdated
@ -837,6 +907,7 @@ def populate_global_pkgset(compose, koji_wrapper, path_prefix, event):
cache_region=compose.cache_region,
extra_builds=extra_builds,
extra_tasks=extra_tasks,
jhernandez commented 2023-03-20 11:45:21 +00:00
Member
Copy Link

on purpose empty line?

on purpose empty line?
soksanichenko marked this conversation as resolved
jhernandez reviewed 2023-03-20 11:45:29 +00:00
pungi/phases/pkgset/sources/source_kojimock.py Outdated
@ -847,6 +918,7 @@ def populate_global_pkgset(compose, koji_wrapper, path_prefix, event):
if old_cache_path:
pkgset.set_old_file_cache(
pungi.phases.pkgset.pkgsets.KojiPackageSet.load_old_file_cache(
jhernandez commented 2023-03-20 11:45:29 +00:00
Member
Copy Link

same as above

same as above
soksanichenko marked this conversation as resolved
jhernandez approved these changes 2023-03-20 11:46:27 +00:00
jhernandez left a comment
Member
Copy Link

Left minor style-related comments. Other than that, LGTM

Left minor style-related comments. Other than that, LGTM
soksanichenko added 1 commit 2023-03-20 11:55:15 +00:00 
- Style fix
soksanichenko added 1 commit 2023-03-20 11:56:51 +00:00 
- Redundant empty lines are removed
jhernandez reviewed 2023-03-20 12:01:51 +00:00
pungi/phases/pkgset/sources/source_kojimock.py
@ -39,3 +40,4 @@
retry,
get_arch_variant_data,
get_variant_data,
jhernandez commented 2023-03-20 12:01:51 +00:00
Member
Copy Link

extra empty line

extra empty line
soksanichenko merged commit 60a347a4a2 into al_master 2023-03-22 10:06:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jhernandez
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: almalinux/pungi#14
No description provided.
Delete Branch "ALBS-1030"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?