diff --git a/pungi/phases/buildinstall.py b/pungi/phases/buildinstall.py index 2e9973ce..007233ce 100644 --- a/pungi/phases/buildinstall.py +++ b/pungi/phases/buildinstall.py @@ -182,7 +182,11 @@ class BuildinstallPhase(PhaseBase): self.pool.start() def succeeded(self, variant, arch): - return (variant.uid if self.used_lorax else None, arch) in self.pool.finished_tasks + # If the phase is skipped, we can treat it as successful. Either there + # will be no output, or it's a debug run of compose where anything can + # happen. + return (super(BuildinstallPhase, self).skip() + or (variant.uid if self.used_lorax else None, arch) in self.pool.finished_tasks) def copy_files(self): disc_type = self.compose.conf['disc_types'].get('dvd', 'dvd') diff --git a/tests/test_buildinstall.py b/tests/test_buildinstall.py index 19b9b8b9..c930f589 100644 --- a/tests/test_buildinstall.py +++ b/tests/test_buildinstall.py @@ -31,6 +31,8 @@ class BuildInstallCompose(DummyCompose): } self.all_variants = self.variants.copy() self.has_comps = True + self.just_phases = [] + self.skip_phases = [] class TestBuildinstallPhase(PungiTestCase):