almalinux/pungi
14
1
Fork 0
Code Issues Pull Requests Releases Activity

comps-wrapper: Minor code cleanup

Browse Source 
Use context manager for opening file, reduce duplication in creating
nodes with boolean values.

Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
This commit is contained in:
Lubomír Sedlář 2017-04-12 13:04:47 +02:00
parent fbf189d9c7
commit e5dc69cd41
1 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
pungi/wrappers/comps.py
View File

@ -53,10 +53,9 @@ class CompsWrapper(object):
comps_obj = self.generate_comps() comps_obj = self.generate_comps()
if not target_file: if not target_file:
target_file = self.comps_file target_file = self.comps_file
stream = open(target_file, "w")
# comps_obj.writexml(stream, addindent=" ", newl="\n") # no encoding -> use toprettyxml() with open(target_file, "w") as stream:
stream.write(comps_obj.toprettyxml(indent=" ", encoding="UTF-8")) stream.write(comps_obj.toprettyxml(indent=" ", encoding="UTF-8"))
stream.close()
def generate_comps(self): def generate_comps(self):
impl = xml.dom.minidom.getDOMImplementation() impl = xml.dom.minidom.getDOMImplementation()
@ -109,20 +108,11 @@ class CompsWrapper(object):
group_node.appendChild(node) group_node.appendChild(node)
node = doc.createElement("default") node = doc.createElement("default")
node.appendChild(doc.createTextNode("true" if group.default else "false"))
if group.default:
node.appendChild(doc.createTextNode("true"))
else:
node.appendChild(doc.createTextNode("false"))
group_node.appendChild(node) group_node.appendChild(node)
node = doc.createElement("uservisible") node = doc.createElement("uservisible")
node.appendChild(doc.createTextNode("true" if group.user_visible else "false"))
if group.user_visible:
node.appendChild(doc.createTextNode("true"))
else:
node.appendChild(doc.createTextNode("false"))
group_node.appendChild(node) group_node.appendChild(node)
if group.langonly: if group.langonly:
@ -187,7 +177,7 @@ class CompsWrapper(object):
if category.display_order is not None: if category.display_order is not None:
display_node = doc.createElement("display_order") display_node = doc.createElement("display_order")
display_node.appendChild(doc.createTextNode("%s" % category.display_order)) display_node.appendChild(doc.createTextNode(str(category.display_order)))
cat_node.appendChild(display_node) cat_node.appendChild(display_node)
grouplist_node = doc.createElement("grouplist") grouplist_node = doc.createElement("grouplist")