Fix minor Ruff/flake8 warnings
```
pungi/checks.py:575:17: F601 [*] Dictionary key literal `"type"` repeated
pungi/phases/pkgset/pkgsets.py:617:12: E721 Do not compare types, use `isinstance()`
tests/test_pkgset_source_koji.py:241:16: E721 Do not compare types, use `isinstance()`
tests/test_pkgset_source_koji.py:244:16: E721 Do not compare types, use `isinstance()`
tests/test_pkgset_source_koji.py:370:16: E721 Do not compare types, use `isinstance()`
tests/test_pkgset_source_koji.py:374:20: E721 Do not compare types, use `isinstance()`
```
Signed-off-by: Timothée Ravier <tim@siosm.fr>
(cherry picked from commit 2534ddee99
)
This commit is contained in:
parent
323d1c1eb6
commit
aba5a7a093
@ -572,7 +572,6 @@ def make_schema():
|
||||
},
|
||||
"required": ["kickstart"],
|
||||
"additionalProperties": False,
|
||||
"type": "object",
|
||||
},
|
||||
"osbs_config": {
|
||||
"type": "object",
|
||||
|
@ -625,7 +625,7 @@ class KojiPackageSet(PackageSetBase):
|
||||
result_srpms = []
|
||||
include_packages = set(include_packages or [])
|
||||
|
||||
if type(event) is dict:
|
||||
if isinstance(event, dict):
|
||||
event = event["id"]
|
||||
|
||||
msg = "Getting latest RPMs (tag: %s, event: %s, inherit: %s)" % (
|
||||
|
@ -244,10 +244,10 @@ class TestGetPackageSetFromKoji(helpers.PungiTestCase):
|
||||
self.compose, self.koji_wrapper, event, module_info_str
|
||||
)
|
||||
|
||||
assert type(result) is list
|
||||
assert isinstance(result, list)
|
||||
assert len(result) == 1
|
||||
module = result[0]
|
||||
assert type(module) is dict
|
||||
assert isinstance(module, dict)
|
||||
self.assertIn("module_stream", module)
|
||||
self.assertIn("module_version", module)
|
||||
self.assertIn("module_context", module)
|
||||
@ -373,11 +373,11 @@ class TestGetPackageSetFromKoji(helpers.PungiTestCase):
|
||||
self.compose, self.koji_wrapper, event, module_info_str
|
||||
)
|
||||
|
||||
assert type(result) is list
|
||||
assert isinstance(result, list)
|
||||
assert len(result) == 2
|
||||
module = result[0]
|
||||
for module in result:
|
||||
assert type(module) is dict
|
||||
assert isinstance(module, dict)
|
||||
self.assertIn("module_stream", module)
|
||||
self.assertIn("module_version", module)
|
||||
self.assertIn("module_context", module)
|
||||
|
Loading…
Reference in New Issue
Block a user