From a1ebd234a4f9e64f4476d827e5c450a7c02157c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubom=C3=ADr=20Sedl=C3=A1=C5=99?= Date: Fri, 10 Sep 2021 11:29:31 +0200 Subject: [PATCH] Only build CTS url when configured MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit JIRA: RHELCMP-6611 Signed-off-by: Lubomír Sedlář --- pungi/compose.py | 17 +++++++++-------- pungi/scripts/pungi_koji.py | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/pungi/compose.py b/pungi/compose.py index a43d899e..37f63449 100644 --- a/pungi/compose.py +++ b/pungi/compose.py @@ -157,14 +157,15 @@ def update_compose_url(compose_dir, conf): compose_id = f.read() authentication = get_authentication(conf) cts_url = conf.get("cts_url", None) - url = os.path.join(cts_url, "api/1/composes", compose_id) - tp = conf.get("translate_paths", None) - compose_url = translate_path_raw(tp, compose_dir) - data = { - "action": "set_url", - "compose_url": compose_url, - } - return requests.patch(url, json=data, auth=authentication) + if cts_url: + url = os.path.join(cts_url, "api/1/composes", compose_id) + tp = conf.get("translate_paths", None) + compose_url = translate_path_raw(tp, compose_dir) + data = { + "action": "set_url", + "compose_url": compose_url, + } + return requests.patch(url, json=data, auth=authentication) def get_compose_dir( diff --git a/pungi/scripts/pungi_koji.py b/pungi/scripts/pungi_koji.py index b8d899bc..6f1b92a6 100644 --- a/pungi/scripts/pungi_koji.py +++ b/pungi/scripts/pungi_koji.py @@ -330,7 +330,7 @@ def main(): ) rv = Compose.update_compose_url(compose_dir, conf) - if not rv.ok: + if rv and not rv.ok: logger.error("CTS compose_url update failed with the error: %s" % rv.text) errors, warnings = pungi.checks.validate(conf, offline=False)