almalinux/pungi
14
1
Fork 0
Code Issues Pull Requests Releases Activity

pkgset: Report better error when module is missing an arch

Browse Source 
Pungi expects each module to be built for all architectures by default.
Unless the module is filtered out, missing metadata for a particular
arch would cause it to crash with a incomprehensible error message. This
should make it a little better.

Relates: https://pagure.io/releng/failed-composes/issue/3889
Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
This commit is contained in:
Lubomír Sedlář 2022-08-25 10:59:15 +02:00 committed by lsedlar
parent 779793386c
commit 8aba2363e2
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pungi/phases/pkgset/sources/source_koji.py
View File

@ -264,8 +264,14 @@ def _add_module_to_variant(
compose.log_debug("Module %s is filtered from %s.%s", nsvc, variant, arch) compose.log_debug("Module %s is filtered from %s.%s", nsvc, variant, arch)
continue continue
filename = "modulemd.%s.txt" % arch
if filename not in mmds:
raise RuntimeError(
"Module %s does not have metadata for arch %s and is not filtered "
"out via filter_modules option." % (nsvc, arch)
)
mod_stream = read_single_module_stream_from_file( mod_stream = read_single_module_stream_from_file(
mmds["modulemd.%s.txt" % arch], compose, arch, build mmds[filename], compose, arch, build
) )
if mod_stream: if mod_stream:
added = True added = True