From 860360629d67f6b4980b6f89cbcd859979046ff9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubom=C3=ADr=20Sedl=C3=A1=C5=99?= Date: Fri, 19 Jan 2024 10:32:26 +0100 Subject: [PATCH] Add workaround for old requests in kojiwrapper MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When running with requests<2.18 (i.e. on RHEL 7), streaming responses are not a context manager and need to be wrapped in contextlib.closing. Signed-off-by: Lubomír Sedlář --- pungi/wrappers/kojiwrapper.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pungi/wrappers/kojiwrapper.py b/pungi/wrappers/kojiwrapper.py index 7657876f..2f6dc8c8 100644 --- a/pungi/wrappers/kojiwrapper.py +++ b/pungi/wrappers/kojiwrapper.py @@ -959,7 +959,8 @@ class KojiDownloadProxy: :param str dest: file path to store the result in :returns: path to the downloaded file (same as dest) or None if the URL """ - with self.session.get(url, stream=True) as r: + # contextlib.closing is only needed in requests<2.18 + with contextlib.closing(self.session.get(url, stream=True)) as r: if r.status_code == 404: self.logger.warning("GET %s NOT FOUND", url) return None