almalinux/pungi
14
1
Fork 0
Code Issues Pull Requests Releases Activity

koji-wrapper: Handle failed subtasks

Browse Source 
If a subtask fails, we can't ask about it's results as that would raise
an exception. We can safely assume that since the parent succeeded, any
failed child is actually allowed to fail.

Fixes: #641
Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
This commit is contained in:
Lubomír Sedlář 2017-06-12 18:15:29 +02:00
parent d3dd7aa7ce
commit 81b71b9ed3
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pungi/wrappers/kojiwrapper.py
View File

@ -354,6 +354,11 @@ class KojiWrapper(object):
if child_task['method'] not in ['createImage', 'createLiveMedia', 'createAppliance']: if child_task['method'] not in ['createImage', 'createLiveMedia', 'createAppliance']:
continue continue
if child_task['state'] != koji.TASK_STATES['CLOSED']:
# The subtask is failed, which can happen with the can_fail
# option. Let's ignore it then.
continue
is_scratch = child_task['request'][-1].get('scratch', False) is_scratch = child_task['request'][-1].get('scratch', False)
task_result = self.koji_proxy.getTaskResult(child_task['id']) task_result = self.koji_proxy.getTaskResult(child_task['id'])