almalinux/pungi
14
1
Fork 0
Code Issues Pull Requests Releases Activity

Always log stdout before checking for stderr output

Browse Source
This commit is contained in:
Jesse Keating 2007-07-20 16:59:09 -04:00 committed by Jesse Keating
parent 8dd1c2aa93
commit 14e3a3922b
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Changelog
View File

@ -1,5 +1,6 @@
* Fri Jul 20 2007 Jesse Keating <jkeating@redhat.com> * Fri Jul 20 2007 Jesse Keating <jkeating@redhat.com>
- Don't quote things passed to mkisofs, not a shell - Don't quote things passed to mkisofs, not a shell
- Always log stdout before checking for stderr output
* Fri Jul 06 2007 Jesse Keating <jkeating@redhat.com> * Fri Jul 06 2007 Jesse Keating <jkeating@redhat.com>
- Include memtest86+ in the "Fedora" manifest - Include memtest86+ in the "Fedora" manifest

5
pypungi/pungi.py
View File

@ -71,13 +71,14 @@ class Pungi:
p1 = subprocess.Popen(command, cwd=rundir, stdout=output, stderr=error, universal_newlines=True) p1 = subprocess.Popen(command, cwd=rundir, stdout=output, stderr=error, universal_newlines=True)
(out, err) = p1.communicate() (out, err) = p1.communicate()
log.info(out)
if p1.returncode != 0: if p1.returncode != 0:
log.error("Got an error from %s" % command[0]) log.error("Got an error from %s" % command[0])
log.error(err) log.error(err)
raise OSError, "Got an error from %s" % command[0] raise OSError, "Got an error from %s" % command[0]
log.info(out)
def doBuildinstall(self): def doBuildinstall(self):
"""Run anaconda-runtime's buildinstall on the tree.""" """Run anaconda-runtime's buildinstall on the tree."""