almalinux
/
pungi
15
1
Fork 0
Code Issues Pull Requests Releases Activity

createrepo: Use less verbose logs 

There is really no need to write out megabytes of logs that are not
really interesting. This should also help the parallelization. With the
verbose log createrepo fills the output buffer and needs to wait for the
busy python program to read it first.

Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
This commit is contained in:
Lubomír Sedlář 2018-05-03 08:53:03 +02:00
parent bd9a0ceda2
commit 076be762ec
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pungi/wrappers/createrepo.py
View File

@ -36,7 +36,7 @@ class CreaterepoWrapper(object):
oldpackagedirs=None, num_deltas=None, workers=None, use_xz=False):
# groupfile = /path/to/comps.xml
cmd = [self.createrepo, directory, '--verbose']
cmd = [self.createrepo, directory]
if baseurl:
cmd.append("--baseurl=%s" % baseurl)

8
tests/test_createrepo_wrapper.py
View File

@ -21,7 +21,7 @@ class CreateRepoWrapperTest(unittest.TestCase):
cmd = repo.get_createrepo_cmd('/test/dir')
self.assertEqual(cmd[:2], ['createrepo_c', '/test/dir'])
self.assertItemsEqual(cmd[2:], ['--verbose', '--update', '--database', '--unique-md-filenames'])
self.assertItemsEqual(cmd[2:], ['--update', '--database', '--unique-md-filenames'])
def test_get_createrepo_c_cmd_full(self):
repo = CreaterepoWrapper()
@ -44,7 +44,7 @@ class CreateRepoWrapperTest(unittest.TestCase):
'--checksum=sha256', '--distro=Fedora', '--simple-md-filenames', '--no-database',
'--content=c1', '--content=c2', '--repo=r1', '--repo=r2', '--revision=rev',
'--deltas', '--oldpackagedirs=/test/old', '--num-deltas=2', '--workers=3',
'--outputdir=/test/output', '--verbose', '--xz'])
'--outputdir=/test/output', '--xz'])
def test_get_createrepo_cmd_minimal(self):
repo = CreaterepoWrapper(False)
@ -52,7 +52,7 @@ class CreateRepoWrapperTest(unittest.TestCase):
self.assertEqual(cmd[:2], ['createrepo', '/test/dir'])
self.assertItemsEqual(cmd[2:], ['--update', '--database', '--unique-md-filenames',
'--pretty', '--verbose'])
'--pretty'])
def test_get_createrepo_cmd_full(self):
repo = CreaterepoWrapper(False)
@ -74,4 +74,4 @@ class CreateRepoWrapperTest(unittest.TestCase):
'--checksum=sha256', '--distro=Fedora', '--simple-md-filenames', '--no-database',
'--content=c1', '--content=c2', '--repo=r1', '--repo=r2', '--revision=rev',
'--deltas', '--oldpackagedirs=/test/old', '--num-deltas=2', '--workers=3',
'--outputdir=/test/output', '--verbose'])
'--outputdir=/test/output'])

2
tests/test_initphase.py
View File

@ -139,7 +139,7 @@ class TestCreateCompsRepo(PungiTestCase):
init.create_comps_repo(compose, 'x86_64', None)
self.assertEqual(run.mock_calls,
[mock.call(['createrepo_c', self.topdir + '/work/x86_64/comps_repo', '--verbose',
[mock.call(['createrepo_c', self.topdir + '/work/x86_64/comps_repo',
'--outputdir=%s/work/x86_64/comps_repo' % self.topdir,
'--groupfile=%s/work/x86_64/comps/comps-x86_64.xml' % self.topdir,
'--update', '--skip-stat', '--database', '--checksum=sha256',