almalinux/pungi
14
1
Fork 0
Code Issues Pull Requests Releases Activity
0ee2189d9c
pungi/tests/test_config.py

406 lines
13 KiB
Python
Raw Normal View History

Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
#!/usr/bin/env python
# -*- coding: utf-8 -*-
tests: Use unittest2 consistently Without importing this module, the tests are going to fail on Python 2.6. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-09-22 08:28:01 +00:00
try:
import unittest2 as unittest
except ImportError:
import unittest
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
import os
import sys
sys.path.insert(0, os.path.join(os.path.dirname(__file__), '..'))
from pungi import checks
from tests.helpers import load_config, PKGSET_REPOS
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class ConfigTestCase(unittest.TestCase):
def assertValidation(self, cfg, errors=[], warnings=[]):
actual_errors, actual_warnings = checks.validate(cfg)
self.assertItemsEqual(errors, actual_errors)
self.assertEqual(warnings, actual_warnings)
class PkgsetConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_minimal_pkgset_koji(self):
cfg = load_config(
pkgset_source='koji',
pkgset_koji_tag="f25",
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_minimal_pkgset_repos(self):
cfg = load_config(
pkgset_source='repos',
pkgset_repos={'x86_64': '/first', 'ppc64': '/second'},
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_pkgset_mismatch_repos(self):
cfg = load_config(
pkgset_source='repos',
pkgset_koji_tag='f25',
pkgset_koji_inherit=False,
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
[checks.REQUIRES.format('pkgset_source', 'repos', 'pkgset_repos'),
checks.CONFLICTS.format('pkgset_source', 'repos', 'pkgset_koji_tag'),
checks.CONFLICTS.format('pkgset_source', 'repos', 'pkgset_koji_inherit')])
def test_pkgset_mismatch_koji(self):
cfg = load_config(
pkgset_source='koji',
pkgset_repos={'whatever': '/foo'},
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
[checks.REQUIRES.format('pkgset_source', 'koji', 'pkgset_koji_tag'),
checks.CONFLICTS.format('pkgset_source', 'koji', 'pkgset_repos')])
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class ReleaseConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_layered_without_base_product(self):
cfg = load_config(
PKGSET_REPOS,
release_is_layered=True
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
[checks.REQUIRES.format('release_is_layered', 'True', 'base_product_name'),
checks.REQUIRES.format('release_is_layered', 'True', 'base_product_short'),
checks.REQUIRES.format('release_is_layered', 'True', 'base_product_version')])
def test_not_layered_with_base_product(self):
cfg = load_config(
PKGSET_REPOS,
base_product_name='Prod',
base_product_short='bp',
base_product_version='1.0',
base_product_type='updates',
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
[checks.CONFLICTS.format('release_is_layered', 'False', 'base_product_name'),
checks.CONFLICTS.format('release_is_layered', 'False', 'base_product_short'),
checks.CONFLICTS.format('release_is_layered', 'False', 'base_product_type'),
checks.CONFLICTS.format('release_is_layered', 'False', 'base_product_version')])
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class RunrootConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_runroot_without_deps(self):
cfg = load_config(
PKGSET_REPOS,
runroot=True,
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
[checks.REQUIRES.format('runroot', 'True', 'koji_profile'),
checks.REQUIRES.format('runroot', 'True', 'runroot_tag'),
checks.REQUIRES.format('runroot', 'True', 'runroot_channel')])
def test_koji_settings_without_runroot(self):
cfg = load_config(
PKGSET_REPOS,
runroot=False,
koji_profile='koji',
runroot_tag='f25',
runroot_channel='compose',
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
[checks.CONFLICTS.format('runroot', 'False', 'runroot_tag'),
checks.CONFLICTS.format('runroot', 'False', 'runroot_channel')])
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class BuildinstallConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_bootable_without_method(self):
cfg = load_config(
PKGSET_REPOS,
bootable=True,
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
[checks.REQUIRES.format('bootable', 'True', 'buildinstall_method')])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_non_bootable_with_method(self):
cfg = load_config(
PKGSET_REPOS,
bootable=False,
buildinstall_method='lorax',
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
[checks.CONFLICTS.format('bootable', 'False', 'buildinstall_method')])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_buildinstall_method_without_bootable(self):
cfg = load_config(
PKGSET_REPOS,
buildinstall_method='lorax',
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
[checks.CONFLICTS.format('bootable', 'False', 'buildinstall_method')])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_buildinstall_with_lorax_options(self):
cfg = load_config(
PKGSET_REPOS,
bootable=True,
buildinstall_method='buildinstall',
lorax_options=[('^Server$', {})]
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
[checks.CONFLICTS.format('buildinstall_method', 'buildinstall', 'lorax_options')])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_lorax_with_lorax_options(self):
cfg = load_config(
PKGSET_REPOS,
bootable=True,
buildinstall_method='lorax',
lorax_options=[]
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_lorax_options_without_bootable_and_method(self):
cfg = load_config(
PKGSET_REPOS,
lorax_options=[('^Server$', {})],
buildinstall_kickstart='foo',
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
[checks.CONFLICTS.format('buildinstall_method', 'None', 'lorax_options'),
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
checks.CONFLICTS.format('buildinstall_method', 'None', 'buildinstall_kickstart')])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_deprecated(self):
cfg = load_config(
PKGSET_REPOS,
buildinstall_upgrade_image=True,
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg, [],
config: Don't abort on deprecated options These options are in fact removed and have no effect anymore. This patch changes the validation to print a warning that the option was removed and what should be done instead. It no longer stops the whole compose. The validation script still rejects configuration files with these removed keys. This change means we no longer check these removals with the JSON schema (as that makes it hard to determine where exactly the problem is). Fixes: #438 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-10-20 08:49:28 +00:00
[checks.REMOVED.format('buildinstall_upgrade_image', 'use lorax_options instead')]
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class CreaterepoConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_minimal_pkgset_koji(self):
cfg = load_config(
pkgset_source='koji',
pkgset_koji_tag="f25",
product_id_allow_missing=True,
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
[checks.CONFLICTS.format('product_id', 'None', 'product_id_allow_missing')])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class GatherConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_source_comps_requires_comps(self):
cfg = load_config(
pkgset_source='koji',
pkgset_koji_tag="f25",
gather_source='comps',
gather_source_mapping='foo'
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
[checks.REQUIRES.format('gather_source', 'comps', 'comps_file'),
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
checks.CONFLICTS.format('gather_source', 'comps', 'gather_source_mapping')])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_source_json_requires_mapping(self):
cfg = load_config(
pkgset_source='koji',
pkgset_koji_tag="f25",
gather_source='json',
comps_file='comps',
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
[checks.REQUIRES.format('gather_source', 'json', 'gather_source_mapping'),
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
checks.CONFLICTS.format('gather_source', 'json', 'comps_file')])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class OSBSConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate(self):
cfg = load_config(
PKGSET_REPOS,
osbs={"^Server$": {
'url': 'http://example.com',
'target': 'f25-build',
}}
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_bad_conf(self):
cfg = load_config(
PKGSET_REPOS,
osbs='yes please'
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertNotEqual(checks.validate(cfg), ([], []))
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class OstreeConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate(self):
cfg = load_config(
PKGSET_REPOS,
ostree=[
("^Atomic$", {
"x86_64": {
"treefile": "fedora-atomic-docker-host.json",
"config_url": "https://git.fedorahosted.org/git/fedora-atomic.git",
checks.py: show warning message for alias option Show warning message for any alias option find in config instance. Example warning message: WARNING: Config option 'product_name' is deprecated and now an alias to 'release_name', please use 'release_name' instead. In: {'release_name': 'dummy product', 'product_name': 'dummy product'} Signed-off-by: Qixiang Wan <qwan@redhat.com>
2017-03-23 15:18:15 +00:00
"repo_from": "Everything",
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
"ostree_repo": "/mnt/koji/compose/atomic/Rawhide/"
}
})
]
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_bad_conf(self):
cfg = load_config(
PKGSET_REPOS,
ostree='yes please'
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertNotEqual(checks.validate(cfg), ([], []))
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class OstreeInstallerConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate(self):
cfg = load_config(
PKGSET_REPOS,
ostree_installer=[
("^Atomic$", {
"x86_64": {
checks.py: show warning message for alias option Show warning message for any alias option find in config instance. Example warning message: WARNING: Config option 'product_name' is deprecated and now an alias to 'release_name', please use 'release_name' instead. In: {'release_name': 'dummy product', 'product_name': 'dummy product'} Signed-off-by: Qixiang Wan <qwan@redhat.com>
2017-03-23 15:18:15 +00:00
"repo_from": "Everything",
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
"release": None,
"installpkgs": ["fedora-productimg-atomic"],
"add_template": ["/spin-kickstarts/atomic-installer/lorax-configure-repo.tmpl"],
"add_template_var": [
"ostree_osname=fedora-atomic",
"ostree_ref=fedora-atomic/Rawhide/x86_64/docker-host",
],
"add_arch_template": ["/spin-kickstarts/atomic-installer/lorax-embed-repo.tmpl"],
Expose lorax's --rootfs-size argument This is going to be necessary for reworking the Atomic Host ISO, see: https://pagure.io/fedora-lorax-templates/pull-request/6 Signed-off-by: Colin Walters <walters@verbum.org>
2016-11-17 15:15:03 +00:00
"rootfs_size": "3",
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
"add_arch_template_var": [
"ostree_repo=https://kojipkgs.fedoraproject.org/compose/atomic/Rawhide/",
"ostree_osname=fedora-atomic",
"ostree_ref=fedora-atomic/Rawhide/x86_64/docker-host",
]
}
})
]
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_bad_conf(self):
cfg = load_config(
PKGSET_REPOS,
ostree_installer=[
("^Atomic$", {
"x86_64": {
checks.py: show warning message for alias option Show warning message for any alias option find in config instance. Example warning message: WARNING: Config option 'product_name' is deprecated and now an alias to 'release_name', please use 'release_name' instead. In: {'release_name': 'dummy product', 'product_name': 'dummy product'} Signed-off-by: Qixiang Wan <qwan@redhat.com>
2017-03-23 15:18:15 +00:00
"repo_from": "Everything",
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
"release": None,
"installpkgs": ["fedora-productimg-atomic"],
"add_template": ["/spin-kickstarts/atomic-installer/lorax-configure-repo.tmpl"],
"add_template_var": [
"ostree_osname=fedora-atomic",
"ostree_ref=fedora-atomic/Rawhide/x86_64/docker-host",
],
"add_arch_template": 15,
"add_arch_template_var": [
"ostree_repo=https://kojipkgs.fedoraproject.org/compose/atomic/Rawhide/",
"ostree_osname=fedora-atomic",
"ostree_ref=fedora-atomic/Rawhide/x86_64/docker-host",
]
}
})
]
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertNotEqual(checks.validate(cfg), ([], []))
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class LiveMediaConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_global_config_validation(self):
cfg = load_config(
PKGSET_REPOS,
live_media_ksurl='git://example.com/repo.git#HEAD',
live_media_target='f24',
live_media_release='RRR',
live_media_version='Rawhide',
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_global_config_null_release(self):
cfg = load_config(
PKGSET_REPOS,
live_media_release=None,
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class TestSuggestions(ConfigTestCase):
init: Remove keep_original_comps option The same information can be inferred from definitions in variants.xml: if the variant has no groups defined, we include packages from all groups. By the same logic we can also include all groups in the comps file. The config validation is updated to give a hint on how to remove the option from the configuration. Relates: #29 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-19 08:09:40 +00:00
def test_with_a_typo(self):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
cfg = load_config(PKGSET_REPOS,
product_pid=None)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg, [], [checks.UNKNOWN_SUGGEST.format('product_pid', 'product_id')])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class TestRegexValidation(ConfigTestCase):
config: Validate variant regular expressions When the mapping in configuration specifies incorrect regular expression to match regular expressions, we should raise an error immediately and not wait until the part of config is actually used. This patch does not cover `live_media`, `image_build` and `osbs` sections, as they use plain dicts and not the list of tuples format. Fixes: #424 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-10-12 07:38:59 +00:00
def test_incorrect_regular_expression(self):
cfg = load_config(PKGSET_REPOS,
multilib=[('^*$', {'*': []})])
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
config: Validate variant regular expressions When the mapping in configuration specifies incorrect regular expression to match regular expressions, we should raise an error immediately and not wait until the part of config is actually used. This patch does not cover `live_media`, `image_build` and `osbs` sections, as they use plain dicts and not the list of tuples format. Fixes: #424 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-10-12 07:38:59 +00:00
['Failed validation in multilib.0.0: incorrect regular '
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
'expression: nothing to repeat'],
[])
config: Validate variant regular expressions When the mapping in configuration specifies incorrect regular expression to match regular expressions, we should raise an error immediately and not wait until the part of config is actually used. This patch does not cover `live_media`, `image_build` and `osbs` sections, as they use plain dicts and not the list of tuples format. Fixes: #424 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-10-12 07:38:59 +00:00
repoclosure: add option to use dnf backend This adds a new option repoclosure_backend that changes what tool is used for repoclosure. Checking build dependencies is currently not supported, as `dnf` does not have the corresponding option. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-01-26 08:19:12 +00:00
class RepoclosureTestCase(ConfigTestCase):
def test_invalid_backend(self):
cfg = load_config(
PKGSET_REPOS,
repoclosure_backend='fnd', # Intentionally with a typo
)
self.assertValidation(
cfg,
["Failed validation in repoclosure_backend: 'fnd' is not one of ['yum', 'dnf']"])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
if __name__ == '__main__':
unittest.main()
Reference in New Issue Copy Permalink