almalinux/pungi
14
1
Fork 0
Code Issues Pull Requests Releases Activity
centos_master
pungi/tests/test_config.py

529 lines
16 KiB
Python
Raw Permalink Normal View History

Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
# -*- coding: utf-8 -*-
tests: Use unittest2 consistently Without importing this module, the tests are going to fail on Python 2.6. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-09-22 08:28:01 +00:00
try:
import unittest2 as unittest
except ImportError:
import unittest
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
Port to Python 3 This should make all tests pass on both Python 2 and Python 3. Unittest2 is required on Py 2.6 and Py 3. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-05 08:01:21 +00:00
import six
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
import mock
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
from pungi import checks
from tests.helpers import load_config, PKGSET_REPOS
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class ConfigTestCase(unittest.TestCase):
def assertValidation(self, cfg, errors=[], warnings=[]):
actual_errors, actual_warnings = checks.validate(cfg)
Remove usage of unittest2 on Python 3 It was needed to provide assertItemsEqual method. Starting with Python 3.2, there's assertCountEqual that does the same thing. Six provides a helper that will dispatch to the existing method. With this change, unittest 2 is only needed on Python 2.6 to backport the method. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2019-10-04 12:45:03 +00:00
six.assertCountEqual(self, errors, actual_errors)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertEqual(warnings, actual_warnings)
class PkgsetConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_minimal_pkgset_koji(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
pkgset_source="koji",
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_minimal_pkgset_repos(self):
cfg = load_config(
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
pkgset_source="repos",
pkgset_repos={"x86_64": "/first", "ppc64": "/second"},
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_pkgset_mismatch_repos(self):
cfg = load_config(
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
pkgset_source="repos",
pkgset_koji_tag="f25",
pkgset_koji_inherit=False,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
[
checks.REQUIRES.format("pkgset_source", "repos", "pkgset_repos"),
checks.CONFLICTS.format("pkgset_source", "repos", "pkgset_koji_tag"),
checks.CONFLICTS.format(
"pkgset_source", "repos", "pkgset_koji_inherit"
),
],
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_pkgset_mismatch_koji(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
pkgset_source="koji",
pkgset_repos={"whatever": "/foo"},
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
cfg, [checks.CONFLICTS.format("pkgset_source", "koji", "pkgset_repos")]
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
pkgset: Allow populating packages from multiple koji tags One of the use cases is https://pagure.io/odcs/issue/7. Merges: #660 Signed-off-by: Qixiang Wan <qwan@redhat.com>
2017-06-27 11:48:02 +00:00
def test_pkgset_multiple_koji_tags(self):
cfg = load_config(
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
pkgset_source="koji",
pkgset_koji_tag=["f25", "f25-extra"],
pkgset: Allow populating packages from multiple koji tags One of the use cases is https://pagure.io/odcs/issue/7. Merges: #660 Signed-off-by: Qixiang Wan <qwan@redhat.com>
2017-06-27 11:48:02 +00:00
pkgset_koji_inherit=False,
)
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class ReleaseConfigTestCase(ConfigTestCase):
config: Deprecate release_is_layered option Fixes: https://pagure.io/pungi/issue/977 Merges: https://pagure.io/pungi/pull-request/1204 Signed-off-by: Haibo Lin <hlin@redhat.com>
2019-06-03 06:55:40 +00:00
def test_set_release_is_layered(self):
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
cfg = load_config(PKGSET_REPOS, release_is_layered=True)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
config: Deprecate release_is_layered option Fixes: https://pagure.io/pungi/issue/977 Merges: https://pagure.io/pungi/pull-request/1204 Signed-off-by: Haibo Lin <hlin@redhat.com>
2019-06-03 06:55:40 +00:00
warnings=[
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
"WARNING: Config option release_is_layered was removed and has no effect; remove it. It's layered if there's configuration for base product." # noqa: E501
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
],
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Deprecate release_is_layered option Fixes: https://pagure.io/pungi/issue/977 Merges: https://pagure.io/pungi/pull-request/1204 Signed-off-by: Haibo Lin <hlin@redhat.com>
2019-06-03 06:55:40 +00:00
def test_only_config_base_product_name(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
base_product_name="Prod",
)
config: Deprecate release_is_layered option Fixes: https://pagure.io/pungi/issue/977 Merges: https://pagure.io/pungi/pull-request/1204 Signed-off-by: Haibo Lin <hlin@redhat.com>
2019-06-03 06:55:40 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
[
checks.REQUIRES.format(
"base_product_name", "Prod", "base_product_short"
),
checks.REQUIRES.format(
"base_product_name", "Prod", "base_product_version"
),
checks.CONFLICTS.format(
"base_product_short", None, "base_product_name"
),
checks.CONFLICTS.format(
"base_product_version", None, "base_product_name"
),
],
)
config: Deprecate release_is_layered option Fixes: https://pagure.io/pungi/issue/977 Merges: https://pagure.io/pungi/pull-request/1204 Signed-off-by: Haibo Lin <hlin@redhat.com>
2019-06-03 06:55:40 +00:00
def test_only_config_base_product_short(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
base_product_short="bp",
)
config: Deprecate release_is_layered option Fixes: https://pagure.io/pungi/issue/977 Merges: https://pagure.io/pungi/pull-request/1204 Signed-off-by: Haibo Lin <hlin@redhat.com>
2019-06-03 06:55:40 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
[
checks.REQUIRES.format("base_product_short", "bp", "base_product_name"),
checks.REQUIRES.format(
"base_product_short", "bp", "base_product_version"
),
checks.CONFLICTS.format(
"base_product_name", None, "base_product_short"
),
checks.CONFLICTS.format(
"base_product_version", None, "base_product_short"
),
],
)
config: Deprecate release_is_layered option Fixes: https://pagure.io/pungi/issue/977 Merges: https://pagure.io/pungi/pull-request/1204 Signed-off-by: Haibo Lin <hlin@redhat.com>
2019-06-03 06:55:40 +00:00
def test_only_config_base_product_version(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
base_product_version="1.0",
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
[
checks.REQUIRES.format(
"base_product_version", "1.0", "base_product_name"
),
checks.REQUIRES.format(
"base_product_version", "1.0", "base_product_short"
),
checks.CONFLICTS.format(
"base_product_name", None, "base_product_version"
),
checks.CONFLICTS.format(
"base_product_short", None, "base_product_version"
),
],
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
Configure image name per variant Up to now it was possible to change the pattern for all images, but there are use-cases where different variants might want different names. For example there could be one main variant that should only have product name in the ISO filename, but addons should still be marked with variant name. JIRA: COMPOSE-3041 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2018-11-01 09:07:38 +00:00
class ImageNameConfigTestCase(ConfigTestCase):
def test_image_name_simple_string(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
image_name_format="foobar",
)
Configure image name per variant Up to now it was possible to change the pattern for all images, but there are use-cases where different variants might want different names. For example there could be one main variant that should only have product name in the ISO filename, but addons should still be marked with variant name. JIRA: COMPOSE-3041 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2018-11-01 09:07:38 +00:00
self.assertValidation(cfg, [])
def test_image_name_variant_mapping(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
image_name_format={"^Server$": "foobar"},
)
Configure image name per variant Up to now it was possible to change the pattern for all images, but there are use-cases where different variants might want different names. For example there could be one main variant that should only have product name in the ISO filename, but addons should still be marked with variant name. JIRA: COMPOSE-3041 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2018-11-01 09:07:38 +00:00
self.assertValidation(cfg, [])
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class RunrootConfigTestCase(ConfigTestCase):
config: Deprecate runroot option Fixes: https://pagure.io/pungi/issue/975 Signed-off-by: Haibo Lin <hlin@redhat.com>
2019-06-24 08:18:55 +00:00
def test_set_runroot_true(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
runroot=True,
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
warnings=[
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
"WARNING: Config option runroot was removed and has no effect; remove it. Please specify 'runroot_method' if you want to enable runroot, otherwise run things locally." # noqa: E501
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
],
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Deprecate runroot option Fixes: https://pagure.io/pungi/issue/975 Signed-off-by: Haibo Lin <hlin@redhat.com>
2019-06-24 08:18:55 +00:00
def test_set_runroot_false(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
runroot=False,
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
warnings=[
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
"WARNING: Config option runroot was removed and has no effect; remove it. Please specify 'runroot_method' if you want to enable runroot, otherwise run things locally." # noqa: E501
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
],
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class BuildinstallConfigTestCase(ConfigTestCase):
config: Deprecate bootable option JIRA: COMPOSE-2635 Fixes: https://pagure.io/pungi/issue/976 Signed-off-by: Haibo Lin <hlin@redhat.com>
2019-07-22 07:29:47 +00:00
def test_bootable_deprecated(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
bootable=True,
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
warnings=[
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
"WARNING: Config option bootable was removed and has no effect; remove it. Setting buildinstall_method option if you want a bootable installer." # noqa: E501
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
],
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_buildinstall_method_without_bootable(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
buildinstall_method="lorax",
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
self.assertValidation(cfg, [])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_lorax_with_lorax_options(self):
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
cfg = load_config(PKGSET_REPOS, buildinstall_method="lorax", lorax_options=[])
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_lorax_options_without_bootable_and_method(self):
cfg = load_config(
PKGSET_REPOS,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
lorax_options=[("^Server$", {})],
buildinstall_kickstart="foo",
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
[
checks.CONFLICTS.format("buildinstall_method", "None", "lorax_options"),
checks.CONFLICTS.format(
"buildinstall_method", "None", "buildinstall_kickstart"
),
],
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class CreaterepoConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_minimal_pkgset_koji(self):
cfg = load_config(
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
pkgset_source="koji",
pkgset_koji_tag="f25",
product_id_allow_missing=True,
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
[checks.CONFLICTS.format("product_id", "None", "product_id_allow_missing")],
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class GatherConfigTestCase(ConfigTestCase):
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
def test_dnf_backend_is_default_on_py3(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
pkgset_source="koji",
pkgset_koji_tag="f27",
)
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
with mock.patch("six.PY2", new=False):
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
self.assertValidation(cfg, [])
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
self.assertEqual(cfg["gather_backend"], "dnf")
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
def test_yum_backend_is_default_on_py2(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
pkgset_source="koji",
pkgset_koji_tag="f27",
)
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
with mock.patch("six.PY2", new=True):
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
self.assertValidation(cfg, [])
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
self.assertEqual(cfg["gather_backend"], "yum")
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
def test_yum_backend_is_rejected_on_py3(self):
cfg = load_config(
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
pkgset_source="koji",
pkgset_koji_tag="f27",
gather_backend="yum",
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
)
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
with mock.patch("six.PY2", new=False):
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
["Failed validation in gather_backend: 'yum' is not one of ['dnf']"],
)
Reject yum gather backend on Python 3 It will not run, and having a nice error message is better than a cryptic crash. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-21 07:41:43 +00:00
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class OSBSConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate(self):
cfg = load_config(
PKGSET_REPOS,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
osbs={
"^Server$": {
"url": "http://example.com",
"target": "f25-build",
"git_branch": "f25",
}
},
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_bad_conf(self):
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
cfg = load_config(PKGSET_REPOS, osbs="yes please")
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertNotEqual(checks.validate(cfg), ([], []))
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class OstreeConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate(self):
cfg = load_config(
PKGSET_REPOS,
ostree=[
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
(
"^Atomic$",
{
"x86_64": {
"treefile": "fedora-atomic-docker-host.json",
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
"config_url": "https://git.fedorahosted.org/git/fedora-atomic.git", # noqa: E501
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
"repo": "Everything",
"ostree_repo": "/mnt/koji/compose/atomic/Rawhide/",
"version": "!OSTREE_VERSION_FROM_LABEL_DATE_TYPE_RESPIN",
}
},
)
],
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_bad_conf(self):
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
cfg = load_config(PKGSET_REPOS, ostree="yes please")
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertNotEqual(checks.validate(cfg), ([], []))
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class OstreeInstallerConfigTestCase(ConfigTestCase):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate(self):
cfg = load_config(
PKGSET_REPOS,
ostree_installer=[
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
(
"^Atomic$",
{
"x86_64": {
"repo": "Everything",
"release": None,
"installpkgs": ["fedora-productimg-atomic"],
"add_template": [
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
"/spin-kickstarts/atomic-installer/lorax-configure-repo.tmpl" # noqa: E501
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
],
"add_template_var": [
"ostree_osname=fedora-atomic",
"ostree_ref=fedora-atomic/Rawhide/x86_64/docker-host",
],
"add_arch_template": [
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
"/spin-kickstarts/atomic-installer/lorax-embed-repo.tmpl" # noqa: E501
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
],
"rootfs_size": "3",
"add_arch_template_var": [
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
"ostree_repo=https://kojipkgs.fedoraproject.org/compose/atomic/Rawhide/", # noqa: E501
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
"ostree_osname=fedora-atomic",
"ostree_ref=fedora-atomic/Rawhide/x86_64/docker-host",
],
}
},
)
],
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_validate_bad_conf(self):
cfg = load_config(
PKGSET_REPOS,
ostree_installer=[
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
(
"^Atomic$",
{
"x86_64": {
"repo": "Everything",
"release": None,
"installpkgs": ["fedora-productimg-atomic"],
"add_template": [
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
"/spin-kickstarts/atomic-installer/lorax-configure-repo.tmpl" # noqa: E501
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
],
"add_template_var": [
"ostree_osname=fedora-atomic",
"ostree_ref=fedora-atomic/Rawhide/x86_64/docker-host",
],
"add_arch_template": 15,
"add_arch_template_var": [
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
"ostree_repo=https://kojipkgs.fedoraproject.org/compose/atomic/Rawhide/", # noqa: E501
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
"ostree_osname=fedora-atomic",
"ostree_ref=fedora-atomic/Rawhide/x86_64/docker-host",
],
}
},
)
],
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
)
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertNotEqual(checks.validate(cfg), ([], []))
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class LiveMediaConfigTestCase(ConfigTestCase):
Move resolving git reference to config validation Instead of multiple places handling the same thing duplicating the logic, it's better to do it once upfront. This allows easy caching of the results. Additional advantage of this approach is that the config dump will include resolved URLs. The original reference will still be available in the copy of the original config. JIRA: COMPOSE-3065 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2018-11-21 09:56:22 +00:00
@mock.patch("pungi.util.resolve_git_url")
def test_global_config_validation(self, resolve_git_url):
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
cfg = load_config(
PKGSET_REPOS,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
live_media_ksurl="git://example.com/repo.git#HEAD",
live_media_target="f24",
live_media_release="RRR",
live_media_version="Rawhide",
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
)
Add support for git-credential-helper This patch adds an additional field `options` to scm_dict, which can be used to provide additional information to the backends. It implements a single new option for GitWrapper. This option allows setting a custom git credentials wrapper. This can be useful if Pungi needs to get files from a git repository that requires authentication. The helper can be as simple as this (assuming the username is already provided in the url): #!/bin/sh echo password=i-am-secret The helper would need to be referenced by an absolute path from the pungi configuration, or prefixed with ! to have git interpret it as a shell script and look it up in PATH. See https://git-scm.com/docs/gitcredentials for more details. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com> JIRA: RHELCMP-11808
2023-06-14 11:08:31 +00:00
resolve_git_url.side_effect = lambda x, _helper: x.replace("HEAD", "CAFE")
Move resolving git reference to config validation Instead of multiple places handling the same thing duplicating the logic, it's better to do it once upfront. This allows easy caching of the results. Additional advantage of this approach is that the config dump will include resolved URLs. The original reference will still be available in the copy of the original config. JIRA: COMPOSE-3065 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2018-11-21 09:56:22 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Move resolving git reference to config validation Instead of multiple places handling the same thing duplicating the logic, it's better to do it once upfront. This allows easy caching of the results. Additional advantage of this approach is that the config dump will include resolved URLs. The original reference will still be available in the copy of the original config. JIRA: COMPOSE-3065 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2018-11-21 09:56:22 +00:00
self.assertEqual(cfg["live_media_ksurl"], "git://example.com/repo.git#CAFE")
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
def test_global_config_null_release(self):
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
live_media_release=None,
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
self.assertValidation(cfg)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class TestSuggestions(ConfigTestCase):
init: Remove keep_original_comps option The same information can be inferred from definitions in variants.xml: if the variant has no groups defined, we include packages from all groups. By the same logic we can also include all groups in the comps file. The config validation is updated to give a hint on how to remove the option from the configuration. Relates: #29 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-19 08:09:40 +00:00
def test_with_a_typo(self):
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
cfg = load_config(PKGSET_REPOS, product_pid=None)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
self.assertValidation(
cfg, [], [checks.UNKNOWN_SUGGEST.format("product_pid", "product_id")]
)
Add JSON Schema for configuration The schema is written in Python to reduce duplication. When configuration is loaded, the validation checks if it's correct and fills in default values. There is a custom extension to the schema to report deprecated options. The config dependencies are implemented as a separate pass. While it's technically possible to express the dependencies in the schema itself, the error messages are not very helpful and it makes the schema much harder to read. Phases no longer define `config_options`. New options should be added to the schema. Since the default values are populated automatically during validation, there is no need to duplicate them into the code. The `pungi-config-validate` script is updated to use the schema and report errors even for deeply nested fields. The dependencies are updated: pungi now depends on `python-jsonschema` (which is already available in Fedora). Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-08-22 14:08:25 +00:00
config: Report unknown options as warnings Given the way config files can include other files, it is entirely possible to use the same config file for both Pungi and Distill. Pungi will however complain about unknown options. This patch reverts part of c38bb480 and moves deprecation handling back into schema validation. The validation method then returns a list of errors and a list of warnings. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-12-07 14:57:35 +00:00
class TestRegexValidation(ConfigTestCase):
config: Validate variant regular expressions When the mapping in configuration specifies incorrect regular expression to match regular expressions, we should raise an error immediately and not wait until the part of config is actually used. This patch does not cover `live_media`, `image_build` and `osbs` sections, as they use plain dicts and not the list of tuples format. Fixes: #424 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-10-12 07:38:59 +00:00
def test_incorrect_regular_expression(self):
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
cfg = load_config(PKGSET_REPOS, multilib=[("^*$", {"*": []})])
config: Validate variant regular expressions When the mapping in configuration specifies incorrect regular expression to match regular expressions, we should raise an error immediately and not wait until the part of config is actually used. This patch does not cover `live_media`, `image_build` and `osbs` sections, as they use plain dicts and not the list of tuples format. Fixes: #424 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-10-12 07:38:59 +00:00
Fix flake8 complaints - E501 E501 line too long (92 > 88 characters) E501 line too long (103 > 88 characters) ... JIRA: COMPOSE-4108 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-02-06 07:09:32 +00:00
msg = "Failed validation in multilib.0.0: incorrect regular expression: nothing to repeat" # noqa: E501
Port to Python 3 This should make all tests pass on both Python 2 and Python 3. Unittest2 is required on Py 2.6 and Py 3. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-05 08:01:21 +00:00
if six.PY3:
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
msg += " at position 1"
Port to Python 3 This should make all tests pass on both Python 2 and Python 3. Unittest2 is required on Py 2.6 and Py 3. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-09-05 08:01:21 +00:00
self.assertValidation(cfg, [msg], [])
config: Validate variant regular expressions When the mapping in configuration specifies incorrect regular expression to match regular expressions, we should raise an error immediately and not wait until the part of config is actually used. This patch does not cover `live_media`, `image_build` and `osbs` sections, as they use plain dicts and not the list of tuples format. Fixes: #424 Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2016-10-12 07:38:59 +00:00
repoclosure: add option to use dnf backend This adds a new option repoclosure_backend that changes what tool is used for repoclosure. Checking build dependencies is currently not supported, as `dnf` does not have the corresponding option. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-01-26 08:19:12 +00:00
class RepoclosureTestCase(ConfigTestCase):
def test_invalid_backend(self):
cfg = load_config(
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
PKGSET_REPOS,
repoclosure_backend="fnd", # Intentionally with a typo
repoclosure: add option to use dnf backend This adds a new option repoclosure_backend that changes what tool is used for repoclosure. Checking build dependencies is currently not supported, as `dnf` does not have the corresponding option. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-01-26 08:19:12 +00:00
)
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
options = ["yum", "dnf"] if six.PY2 else ["dnf"]
repoclosure: add option to use dnf backend This adds a new option repoclosure_backend that changes what tool is used for repoclosure. Checking build dependencies is currently not supported, as `dnf` does not have the corresponding option. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-01-26 08:19:12 +00:00
self.assertValidation(
cfg,
Format tests with black JIRA: COMPOSE-4086 Signed-off-by: Haibo Lin <hlin@redhat.com>
2020-01-22 10:02:22 +00:00
[
"Failed validation in repoclosure_backend: 'fnd' is not one of %s"
% options
],
)
repoclosure: add option to use dnf backend This adds a new option repoclosure_backend that changes what tool is used for repoclosure. Checking build dependencies is currently not supported, as `dnf` does not have the corresponding option. Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
2017-01-26 08:19:12 +00:00
Variant as a lookaside - configuration Relates: COMPOSE-2425 Signed-off-by: Ondrej Nosek <onosek@redhat.com>
2018-04-10 12:27:55 +00:00
class VariantAsLookasideTestCase(ConfigTestCase):
def test_empty(self):
variant_as_lookaside = []
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
variant_as_lookaside=variant_as_lookaside,
)
Variant as a lookaside - configuration Relates: COMPOSE-2425 Signed-off-by: Ondrej Nosek <onosek@redhat.com>
2018-04-10 12:27:55 +00:00
self.assertValidation(cfg)
def test_basic(self):
variant_as_lookaside = [
("Client", "Base"),
("Server", "Client"),
("Everything", "Spin"),
]
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
variant_as_lookaside=variant_as_lookaside,
)
Variant as a lookaside - configuration Relates: COMPOSE-2425 Signed-off-by: Ondrej Nosek <onosek@redhat.com>
2018-04-10 12:27:55 +00:00
self.assertValidation(cfg)
Validation of parameter skip_phases It checks config file value 'skip_phases' for valid phases names. Also checks command-line attribute 'skip-phase' of 'bin/pungi-koji'. JIRA: COMPOSE-2493 Signed-off-by: Ondrej Nosek <onosek@redhat.com>
2018-05-15 11:30:00 +00:00
class SkipPhasesTestCase(ConfigTestCase):
def test_empty(self):
skip_phases = []
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
skip_phases=skip_phases,
)
Validation of parameter skip_phases It checks config file value 'skip_phases' for valid phases names. Also checks command-line attribute 'skip-phase' of 'bin/pungi-koji'. JIRA: COMPOSE-2493 Signed-off-by: Ondrej Nosek <onosek@redhat.com>
2018-05-15 11:30:00 +00:00
self.assertValidation(cfg)
def test_basic(self):
skip_phases = [
"buildinstall",
"gather",
]
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
skip_phases=skip_phases,
)
Validation of parameter skip_phases It checks config file value 'skip_phases' for valid phases names. Also checks command-line attribute 'skip-phase' of 'bin/pungi-koji'. JIRA: COMPOSE-2493 Signed-off-by: Ondrej Nosek <onosek@redhat.com>
2018-05-15 11:30:00 +00:00
self.assertValidation(cfg)
def test_bad_phase_name(self):
skip_phases = [
"gather",
"non-existing-phase_name",
]
Format code Code didn't get well formatted when jenkins unusable. Signed-off-by: Haibo Lin <hlin@redhat.com>
2021-03-02 10:19:05 +00:00
cfg = load_config(
PKGSET_REPOS,
skip_phases=skip_phases,
)
Validation of parameter skip_phases It checks config file value 'skip_phases' for valid phases names. Also checks command-line attribute 'skip-phase' of 'bin/pungi-koji'. JIRA: COMPOSE-2493 Signed-off-by: Ondrej Nosek <onosek@redhat.com>
2018-05-15 11:30:00 +00:00
self.assertNotEqual(checks.validate(cfg), ([], []))
Reference in New Issue Copy Permalink