Commit Graph

40 Commits

Author SHA1 Message Date
Alexander Todorov
a3c934214b Add tests for yumbase and update how we inspect boolean options
.get_default() returns string so make sure we're actually parsing
the value as boolean and not evaluating a non-empty string in a
boolean context (which will always return True)
2018-02-13 10:52:16 +01:00
Alexander Todorov
28e936d990 Add new tests for workspace_read() and workspace_delete() 2018-02-13 10:52:16 +01:00
Alexander Todorov
1045d78640 Add new tests for configure() 2018-02-13 10:52:16 +01:00
Alexander Todorov
c427b772a5 Add more tests for api.recipes
- test against already existing git repository
- test commit_recipe_file() handling of IOError
- update tests for commit_recipe_directory()
  - add asserts on the existing test. Not raising an exception
    isn't enough!
  - add test which exercises the method under test while it handles
    exceptions raised by other methods
- test for list_commits() when the underlying calls fail to convert
  timestamp
- test for find_name() when `name' is not on the list
- tests for get_revision_from_tag()
2018-02-13 10:52:16 +01:00
Brian C. Lane
fe6c769349 Return the commit id for the recipe being read
This adds returning the commit id from read_commit, and a new function
read_recipe_and_id() that returns the commit id and the recipe in a
tuple.

If the commit is passed in, it is used as is. If no commit is passed in
it finds the most recent commit for the file on the selected branch and
returns that.

Missing recipes now raise a RecipeError with an informative message.
eg. "No commits for missing-recipe.toml on the master branch."
2018-02-06 16:55:14 -08:00
Brian C. Lane
29194aef62 Fix yum config directory creation for projects and server tests 2018-02-06 16:55:14 -08:00
Brian C. Lane
3c18a63f76 Add support for other branches to the routes
Passing ?branch=<branch-name> will use the specified branch instead of
master.

The new branch will not exist until a /recipes/new?branch=new-branch
POST is made. At that time the branch will be created based on the
current master branch and the new commit will be added to it.
2018-01-02 13:49:09 -08:00
Martin Pitt
c58b367b6a Fix depsolving empty recipes
- Fix `projects_depsolve()` to not consider a successful empty response
   (rc == 0) as an error.
 - Fix recipe_from_dict() to default modules and packages to empty lists
   instead of `None`, to avoid a Python-ism in the API for consumers and
   stay compatible to the bdcs API.

Fixes #290
2017-12-12 09:23:06 -08:00
Martin Pitt
a6b96c2419 Fix project tests for non-Central time zones
When running tests somewhere else than Central Time, `test_api_time()`
fails like

    AssertionError: '1985-10-27T02:00:00' != '1985-10-26T21:00:00'

`test_yaps_to_project_info()` fails in a similar way.

Pin the time zone to UTC for this test and adjust timestamps to UTC.
2017-12-12 09:23:06 -08:00
Brian C. Lane
a914253102 Add filtering and glob support to /modules/list route 2017-11-22 15:31:21 -08:00
Brian C. Lane
53d6be4703 Add /recipes/freeze route and tests. 2017-11-22 14:46:43 -08:00
Brian C. Lane
4f15fa895b Add /recipes/depsolve route and test 2017-11-22 13:50:02 -08:00
Brian C. Lane
2b43152407 Add /projects and /modules API tests 2017-11-22 10:29:33 -08:00
Brian C. Lane
c57043af9e Add tests for projects module functions 2017-11-21 16:52:02 -08:00
Brian C. Lane
8d8dc3cb1f Add /recipes/diff route and tests 2017-11-14 17:01:35 -08:00
Brian C. Lane
a56ca875ae Add recipe_diff function and helpers.
This takes a pair of Recipe objects and returns a list of diff dicts
that include what was changed between the two recipes.
2017-11-14 16:16:48 -08:00
Brian C. Lane
f8b64ce34d Add POST /recipes/tag/ route and tests 2017-11-13 16:48:56 -08:00
Brian C. Lane
baf8d7c467 Add tag_recipe_commit helper function
And change tests to use it so that both it and tag_file_commit are used.
2017-11-13 16:48:56 -08:00
Brian C. Lane
f56b7ebf38 Add POST /recipes/undo route and tests 2017-11-13 16:48:56 -08:00
Brian C. Lane
dc5a8c6fb4 Change read_recipe_commit to use the recipe name
Callers really shouldn't need to know the details of the filenames, so
change it to convert it internally.
2017-11-13 16:48:56 -08:00
Brian C. Lane
7edf6baeb4 Add revert_recipe function
And adjust the tests to use it so that it covers both revert_recipe and
revert_file.
2017-11-13 16:48:56 -08:00
Brian C. Lane
4858c17fd7 Add DELETE /recipes/delete/<recipe_name> route and tests
Also add numbering to the tests so that they are executed in the
expected order.
2017-11-13 16:48:56 -08:00
Brian C. Lane
45001091be Add delete_recipe helper function and test
Use delete_recipe in the test so that both it and delete_file are
covered.
2017-11-13 16:48:56 -08:00
Brian C. Lane
305f59175d Add DELETE /recipes/workspace/<recipe_name> route and tests
This will delete the workspace copy of the recipe.
2017-11-13 16:48:56 -08:00
Brian C. Lane
0e9f2ddb73 Add tests for POST /recipes/workspace for JSON and TOML
As a side-effect also tests reading workspace only changes from
/recipes/info
2017-11-13 16:48:56 -08:00
Brian C. Lane
b7499f79d3 Add /recipes/new route and tests
This handles json data when the mime type is "application/json" and toml
recipes when it is "text/x-toml"
2017-11-13 16:44:02 -08:00
Brian C. Lane
053662daf0 Split recipe_from_toml into recipe_from_dict helper.
This will be useful for creating Recipe objects from json created dicts.
2017-11-13 16:44:02 -08:00
Brian C. Lane
6d71e2fcc1 Fix the recipe version bumping
Recipe should have its version bumped based on the version from the
previous commit, and not be bumped on the first commit. Fix the code and
the tests.
2017-11-13 16:44:02 -08:00
Brian C. Lane
63f47c2c00 Add /recipes/changes route with tests. 2017-11-09 18:43:42 -08:00
Brian C. Lane
d58b650904 Add /recipes/info route and tests 2017-11-08 17:38:12 -08:00
Brian C. Lane
8607b3519f Add workspace module and tests
This handles the recipe workspace, which is a temporary location to
store recipes before committing them to git. It will be used by the
/recipes/ API.
2017-11-08 13:14:38 -08:00
Brian C. Lane
641ea8c715 Add /recipes/list route and tests
Includes adding a lock for access to the git repo from the API.
2017-11-08 09:46:12 -08:00
Brian C. Lane
ff47432f10 Move the git repo into a subdirectory
And fix the import of recipes (needs to have full path passed in).
2017-11-07 17:11:17 -08:00
Brian C. Lane
e4695bd580 Add basic API Server testing framework 2017-11-07 12:00:35 -08:00
Brian C. Lane
d2fe65c80c Fix list_commits sort order.
It appears that with libgit2 v0.24.6 reverse causes it to list them
newest first. In 0.25.1 it lists them oldest first. On both versions
just using SortMode.TIME gives the desired result of oldest first.
2017-10-25 13:31:35 -07:00
Brian C. Lane
68939a753a Add tests for the pylorax.api.recipes module 2017-10-25 13:31:35 -07:00
Alexander Todorov
806aad3dff Fix mocking the built-in open function for Python2
- fix import of mock module
- account for io.StringIO differences in Python 2
2017-10-24 22:59:21 +03:00
Alexander Todorov
24e0784256 Misc pylint fixes that are reported usually once 2017-10-13 18:58:40 +03:00
Alexander Todorov
66e8861de7 Add first unit test so we can start collecting coverage 2017-10-13 18:58:31 +03:00
Brian C. Lane
2dc38b7a77 Add pylint support to Makefile
This requires pylint and python-pocketlint from EPEL7 to work.
runpylint.py copied from upstream lorax.
2017-10-04 12:11:10 -07:00