Brian C. Lane
2cd4fcfd88
Add error message for offset/limit type errors
2018-06-11 16:54:58 -07:00
Brian C. Lane
9ca9bfe46f
Add error logging to api/v0.py
...
These will end up in the /var/log/lorax-composer/composer.log
2018-06-11 16:54:58 -07:00
Brian C. Lane
950d9df217
Fix server request logging.
...
And switch the other logs to append instead of overwrite on each run.
2018-06-11 16:54:57 -07:00
Brian C. Lane
9f9d227600
Update lorax.spec for lorax-composer
...
Create a lorax-composer subpackage, with the pylorax/api code, systemd
service and runtime requirements in it.
2018-06-11 16:54:57 -07:00
Brian C. Lane
3bbbeb347a
setup.py: Add pylorax.api module to install, and systemd service
...
lorax-composer.service will be installed by default, but not enabled.
It stores recipes at /var/lib/lorax-composer/recipes/
2018-06-11 16:54:57 -07:00
Brian C. Lane
453082ab9f
lorax-composer: Drop unneeded parameters and create missing directories
...
The log directory (and parents) will be created if they are missing.
An empty recipe directory will be created if it doesn't exist.
2018-06-11 16:54:57 -07:00
Brian C. Lane
d701120d90
Add /recipes/diff route and tests
2018-06-11 16:54:57 -07:00
Brian C. Lane
052a8ba991
Add recipe_diff function and helpers.
...
This takes a pair of Recipe objects and returns a list of diff dicts
that include what was changed between the two recipes.
2018-06-11 16:54:57 -07:00
Brian C. Lane
a76e95dcb5
Add POST /recipes/tag/ route and tests
2018-06-11 16:54:57 -07:00
Brian C. Lane
7f1adf120c
Add tag_recipe_commit helper function
...
And change tests to use it so that both it and tag_file_commit are used.
2018-06-11 16:54:57 -07:00
Brian C. Lane
3f4140d5d3
Add POST /recipes/undo route and tests
2018-06-11 16:54:57 -07:00
Brian C. Lane
639d325a0c
Change read_recipe_commit to use the recipe name
...
Callers really shouldn't need to know the details of the filenames, so
change it to convert it internally.
2018-06-11 16:54:57 -07:00
Brian C. Lane
ab6decec0b
Add revert_recipe function
...
And adjust the tests to use it so that it covers both revert_recipe and
revert_file.
2018-06-11 16:54:57 -07:00
Brian C. Lane
c294b7747d
Add DELETE /recipes/delete/<recipe_name> route and tests
...
Also add numbering to the tests so that they are executed in the
expected order.
2018-06-11 16:54:57 -07:00
Brian C. Lane
c937e69d3b
Add delete_recipe helper function and test
...
Use delete_recipe in the test so that both it and delete_file are
covered.
2018-06-11 16:54:57 -07:00
Brian C. Lane
6e453e70dc
Add DELETE /recipes/workspace/<recipe_name> route and tests
...
This will delete the workspace copy of the recipe.
2018-06-11 16:54:57 -07:00
Brian C. Lane
83e13c4ca8
Add tests for POST /recipes/workspace for JSON and TOML
...
As a side-effect also tests reading workspace only changes from
/recipes/info
2018-06-11 16:54:57 -07:00
Brian C. Lane
72b4c4fe28
Add POST /recipes/workspace route
...
Also fix use of workspace in /recipes/info (was using filename instead
of recipe name and logic for changed was backwards).
2018-06-11 16:54:57 -07:00
Brian C. Lane
711cdf53b3
Add /recipes/new route and tests
...
This handles json data when the mime type is "application/json" and toml
recipes when it is "text/x-toml"
2018-06-11 16:54:57 -07:00
Brian C. Lane
7b5115d19c
Split recipe_from_toml into recipe_from_dict helper.
...
This will be useful for creating Recipe objects from json created dicts.
2018-06-11 16:54:57 -07:00
Brian C. Lane
3c75711b30
Fix the recipe version bumping
...
Recipe should have its version bumped based on the version from the
previous commit, and not be bumped on the first commit. Fix the code and
the tests.
2018-06-11 16:54:57 -07:00
Brian C. Lane
02db2afb2b
Add /recipes/changes route with tests.
2018-06-11 16:54:57 -07:00
Brian C. Lane
1e7335a506
Add /recipes/info route and tests
2018-06-11 16:54:57 -07:00
Brian C. Lane
b7f651a631
Add workspace module and tests
...
This handles the recipe workspace, which is a temporary location to
store recipes before committing them to git. It will be used by the
/recipes/ API.
2018-06-11 16:54:57 -07:00
Brian C. Lane
b6fb22133c
Add /recipes/list route and tests
...
Includes adding a lock for access to the git repo from the API.
2018-06-11 16:54:57 -07:00
Brian C. Lane
90a8798f4c
Move the git repo into a subdirectory
...
And fix the import of recipes (needs to have full path passed in).
2018-06-11 16:54:57 -07:00
Brian C. Lane
5b0d662007
Add basic API Server testing framework
2018-06-11 16:54:57 -07:00
Brian C. Lane
596f06d5c0
Fix list_commits sort order.
...
It appears that with libgit2 v0.24.6 reverse causes it to list them
newest first. In 0.25.1 it lists them oldest first. On both versions
just using SortMode.TIME gives the desired result of oldest first.
2018-06-11 16:54:57 -07:00
Brian C. Lane
afdb320266
Add tests for the pylorax.api.recipes module
2018-06-11 16:54:57 -07:00
Brian C. Lane
bfc9c6913f
Add pylorax.api.recipes code for handling the Recipe's Git repository
2018-06-11 16:54:57 -07:00
Alexander Todorov
d71290153e
Fix mocking the built-in open function for Python2
...
- fix import of mock module
- account for io.StringIO differences in Python 2
2018-06-11 16:54:57 -07:00
Alexander Todorov
2cd4f73177
Don't do wildcard imports
2018-06-11 16:54:57 -07:00
Alexander Todorov
e9e6e5701e
Misc pylint fixes that are reported usually once
2018-06-11 16:54:57 -07:00
Alexander Todorov
bf9ed50d51
Fix dangerous-default value warnings
...
when default value is list or dict the default arguments are
instantiated as objects at the time of definition. This is significant
(exposing visible semantics) when the object is mutable. There’s no way
of re-binding that default argument name in the function’s closure. When
function is executed multiple times with its default value the value
will change between executions, possibly leading to strange side effects.
For more information see:
http://satran.in/2012/01/12/python-dangerous-default-value-as-argument.html
2018-06-11 16:54:57 -07:00
Alexander Todorov
a0766b1d70
Don't redefine variables from outer scope
2018-06-11 16:54:57 -07:00
Alexander Todorov
4d8e2b5356
Define all class attributes inside __init__
2018-06-11 16:54:57 -07:00
Alexander Todorov
663b0f8378
Fix logging formatting
2018-06-11 16:54:57 -07:00
Alexander Todorov
18528b4f47
Don't redefine builtins
2018-06-11 16:54:57 -07:00
Alexander Todorov
b15df5a0af
Silence relative import warnings
2018-06-11 16:54:57 -07:00
Alexander Todorov
7f5b492198
pylint fix: unused variable warning
2018-06-11 16:54:57 -07:00
Alexander Todorov
15de3e1687
pylint fix: remove unused imports
2018-06-11 16:54:57 -07:00
Alexander Todorov
54cdb5dbf5
Add make test target and update .gitignore
...
also submit coverage report to Coveralls.io if environment is
configured
2018-06-11 16:54:57 -07:00
Alexander Todorov
f405aedf6e
Add first unit test so we can start collecting coverage
2018-06-11 16:54:57 -07:00
Brian C. Lane
2008a413b6
lorax-composer initial commit
...
The lorax-composer program will launch a BDCS compatible API server
using Flask and Gevent. Currently this is a skeleton application with
only one active route (/api/v0/status).
The API code lives in ./src/pylorax/api/v0.py with related code in other
pylorax/api/* modules.
2018-06-11 16:54:57 -07:00
Brian C. Lane
798023b199
Add pylint support to Makefile
...
This requires pylint and python-pocketlint from EPEL7 to work.
runpylint.py copied from upstream lorax.
2018-06-11 16:54:57 -07:00
Brian C. Lane
bf8be43c90
livemedia-creator: Move core functions into pylorax modules
...
This reduces the amount of code in livemedia-creator to the cmdline
parsing and calling of the installer functions. Moving them into other
modules will allow them to be used by other projects, like the
lorax-composer API server.
2018-06-11 16:54:57 -07:00
Brian C. Lane
47aa2fb215
Automatic commit of package [lorax] release [19.7.1-1].
...
Created by command:
/usr/bin/tito tag --keep-version
2018-06-11 16:27:56 -07:00
Brian C. Lane
c5dfe8e940
Automatic commit of package [lorax] release [19.6.105-1].
...
Created by command:
/usr/bin/tito tag
2018-06-11 14:52:23 -07:00
Brian C. Lane
c746e8b0c3
Retry losetup if loop_attach fails
...
It appears that sometimes the loop device doesn't get setup properly,
this may be a race with other users of loop devices on the system, or
some other mechanism that isn't understood.
To try and prevent total failure when this happens this patch retries
the loop setup 3 times before giving up. Previously it would wait for
the loop device to appear (checking 5 times), that operation is now
executed 3 times with a new losetup attempt each time.
Resolves: rhbz#1589084
2018-06-11 13:56:53 -07:00
Brian C. Lane
f116ee8f05
Add reqpart to example kickstart files
...
This will make sure that platform specific partitions are created when
making partitioned disk images.
Resolves: rhbz#1545289
2018-06-11 13:52:21 -07:00