From bdc09df37b2e443f215feaab79cccebc077cdc16 Mon Sep 17 00:00:00 2001 From: "Brian C. Lane" Date: Tue, 8 Jan 2019 14:47:25 -0800 Subject: [PATCH] Revert "lorax-composer: Cancel running Anaconda process" Drop running pkill. This causes problems if more than one is running on a system (eg. in parallel using mock). It can kill off other processes unrelated to this instance of anaconda. This reverts commit 0ce6d3882b1f61ae07a7ed8dc3f2d02876da07a1. Related: rhbz#1656691 --- src/pylorax/installer.py | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/pylorax/installer.py b/src/pylorax/installer.py index 40c33bee..6317c571 100644 --- a/src/pylorax/installer.py +++ b/src/pylorax/installer.py @@ -21,9 +21,9 @@ import glob import json from math import ceil import os +import subprocess import shutil import socket -import subprocess import tempfile # Use the Lorax treebuilder branch for iso creation @@ -279,10 +279,7 @@ def novirt_cancel_check(cancel_funcs, proc): """ for f in cancel_funcs: if f(): - log.info("Terminating process %d", proc.pid) proc.terminate() - - # NOTE: Have to return and allow execReadlines to call proc.communicate() return True return False @@ -383,7 +380,6 @@ def novirt_install(opts, disk_img, disk_size, cancel_func=None): for line in execReadlines("anaconda", args, reset_lang=False, env_add={"ANACONDA_PRODUCTNAME": opts.project, "ANACONDA_PRODUCTVERSION": opts.releasever}, - reset_handlers=False, callback=lambda p: not novirt_cancel_check(cancel_funcs, p)): log.info(line) @@ -439,12 +435,6 @@ def novirt_install(opts, disk_img, disk_size, cancel_func=None): log.debug("Removing loop device for %s", disk_img) loop_detach("/dev/"+get_loop_name(disk_img)) - # When anaconda crashes or is canceled it leaves pyanaconda.* running - execWithRedirect("pkill", ["-f", "pyanaconda."]) - - # It can also leave dbus running - execWithRedirect("pkill", ["-f", "anaconda-bus.conf"]) - # qemu disk image is used by bare qcow2 images and by Vagrant if opts.image_type: log.info("Converting %s to %s", disk_img, opts.image_type)