rename "runtime" template arg to "runtime_img"

Mako uses "runtime" internally for things, and if you clobber it stuff
will just break in weird ways. So don't do that.

share/ppc.tmpl

@@ -16,7 +16,7 @@ macboot = ""
 %>
 
 mkdir images
-install ${runtime} images
+install ${runtime_img} images
 
 mkdir ${BOOTDIR} ${BOOTDIR}/chrp etc
 install ${ANABOOTDIR}/bootinfo.txt ${BOOTDIR}

share/s390.tmpl

@@ -9,7 +9,7 @@ kernel = kernels[0]
 %>
 
 mkdir images
-install ${runtime} images
+install ${runtime_img} images
 
 install ${ANABOOTDIR}/redhat.exec ${BOOTDIR}
 install ${ANABOOTDIR}/generic.prm ${BOOTDIR}

share/sparc.tmpl

@@ -5,7 +5,7 @@ KERNELDIR=BOOTDIR
 %>
 
 mkdir images
-install ${runtime} images
+install ${runtime_img} images
 
 install boot/*.b ${BOOTDIR}
 install ${ANABOOTDIR}/silo.conf ${BOOTDIR}
@@ -26,5 +26,5 @@ runcmd mkisofs -R -J -T -G /${BOOTDIR}/isofs.b -B ... \
   -sparc-label "${product.name} ${product.version} Boot Disc" \
   -o ${outroot}/images/boot.iso \
   -graft-points boot=${outroot}/${BOOTDIR} \
-                ${runtime}=${outroot}/${runtime}
+                ${runtime_img}=${outroot}/${runtime_img}
 treeinfo images-${basearch} boot.iso images/boot.iso

share/x86.tmpl

@@ -7,7 +7,7 @@ KERNELDIR=PXEBOOTDIR
 %>
 
 mkdir images
-install ${runtime} images
+install ${runtime_img} images
 
 mkdir ${BOOTDIR} ${KERNELDIR}
 install ${SYSLINUXDIR}/isolinux.bin ${BOOTDIR}
@@ -66,7 +66,7 @@ runcmd mkisofs -o ${outroot}/images/boot.iso \
        ${efiargs} -R -J -V '${product.name}' -T -graft-points \
        ${BOOTDIR}=${outroot}/${BOOTDIR} \
        ${KERNELDIR}=${outroot}/${KERNELDIR} \
-       ${runtime}=${outroot}/${runtime} \
+       ${runtime_img}=${outroot}/${runtime_img} \
        ${efigraft}
 runcmd isohybrid ${outroot}/images/boot.iso
 treeinfo images-${basearch} boot.iso images/boot.iso

src/pylorax/treebuilder.py

@@ -143,8 +143,10 @@ class TreeBuilder(object):
     '''Builds the arch-specific boot images.
     inroot should be the installtree root (the newly-built runtime dir)'''
     def __init__(self, product, arch, inroot, outroot, runtime, templatedir=None):
+        # NOTE: if you pass an arg named "runtime" to a mako template it'll
+        # clobber some mako internal variables - hence "runtime_img".
         v = DataHolder(arch=arch, product=product,
-                       inroot=inroot, outroot=outroot, runtime=runtime,
+                       inroot=inroot, outroot=outroot, runtime_img=runtime,
                        basearch=arch.basearch, libdir=arch.libdir,
                        exists = lambda p: _exists(p, root=inroot))
         self.vars = v