almalinux/lorax
13
0
Fork 0
Code Issues Pull Requests Releases Activity

composer-cli: Increase DELETE timeout to 120s

Browse Source 
When the timeout is too short the http library sends the request again.
We return the last response to the user so even if the cancel works they
get an error about the UUID not being valid.

Resolves: rhbz#1788461
This commit is contained in:
Brian C. Lane 2020-01-07 14:12:27 -08:00
parent d20b2f3309
commit 9636a9b1db
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/composer/http_client.py
View File

@ -126,7 +126,7 @@ def get_url_json_unlimited(socket_path, url, total_fn=None):
r_unlimited = http.request("GET", unlimited_url)
return json.loads(r_unlimited.data.decode('utf-8'))
def delete_url_json(socket_path, url):
def delete_url_json(socket_path, url, timeout=120):
"""Send a DELETE request to the url and return JSON response
:param socket_path: Path to the Unix socket to use for API communication
@ -136,7 +136,7 @@ def delete_url_json(socket_path, url):
:returns: The json response from the server
:rtype: dict
"""
http = UnixHTTPConnectionPool(socket_path)
http = UnixHTTPConnectionPool(socket_path, timeout=timeout)
r = http.request("DELETE", url)
return json.loads(r.data.decode("utf-8"))