almalinux/lorax
13
0
Fork 0
Code Issues Pull Requests Releases Activity

executils: Drop bufsize=1 from execReadlines

Browse Source 
startProgram is running in binary mode, so bufsize=1 is invalid. The
ExecLineReader class already breaks it up into lines using readline() so
there is no need to change the default buffering.
This commit is contained in:
Brian C. Lane 2020-01-15 08:50:16 -08:00
parent d265824564
commit 5561bbb3bc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/pylorax/executils.py
View File

@ -327,7 +327,7 @@ def execReadlines(command, argv, stdin=None, root='/', env_prune=None, filter_st
stderr = subprocess.STDOUT stderr = subprocess.STDOUT
try: try:
proc = startProgram(argv, root=root, stdin=stdin, stdout=subprocess.PIPE, stderr=stderr, bufsize=1, proc = startProgram(argv, root=root, stdin=stdin, stdout=subprocess.PIPE, stderr=stderr,
env_prune=env_prune, env_add=env_add, reset_handlers=reset_handlers, reset_lang=reset_lang) env_prune=env_prune, env_add=env_add, reset_handlers=reset_handlers, reset_lang=reset_lang)
except OSError as e: except OSError as e:
with program_log_lock: with program_log_lock: