almalinux/lorax
13
0
Fork 0
Code Issues Pull Requests Releases Activity

Don't exclude /dev from the setfiles in novirt_install

Browse Source 
After a novirt disk image install, we run `setfiles` in the
install root to ensure some SELinux contexts are correct. /dev
is currently excluded from this run. However, as reported and
discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1663040
it seems that with a recent systemd change, startup of many
services will fail if /dev itself is incorrectly labelled, and
in current Rawhide live images, it *is* incorrectly labelled.
Including `/dev` in this setfiles command appears to resolve the
problem in my testing.

Resolves: rhbz#1663040

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This commit is contained in:
Adam Williamson 2019-01-15 10:34:54 -08:00 committed by Brian C. Lane
parent 4885434ac9
commit 2d3f266373
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/pylorax/installer.py
View File

@ -389,7 +389,7 @@ def novirt_install(opts, disk_img, disk_size, cancel_func=None):
log.info(line) log.info(line)
# Make sure the new filesystem is correctly labeled # Make sure the new filesystem is correctly labeled
setfiles_args = ["-e", "/proc", "-e", "/sys", "-e", "/dev", setfiles_args = ["-e", "/proc", "-e", "/sys",
"/etc/selinux/targeted/contexts/files/file_contexts", "/"] "/etc/selinux/targeted/contexts/files/file_contexts", "/"]
if "--dirinstall" in args: if "--dirinstall" in args: