almalinux/lorax
14
0
Fork 0
Code Issues Pull Requests Releases Activity

Don't be overly strict when validating /api/docs/ response in tests

Browse Source 
this avoids comparing against files on disk (and the huge diff the
test runner produces in case of failure). Instead we look for a
200 HTTP response with large enough size and some well known
strings inside the response data.
This commit is contained in:
Alexander Todorov 2018-02-16 11:07:51 +02:00 committed by Brian C. Lane
parent 4144c3937c
commit 06648d415a
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tests/pylorax/test_server.py
View File

@ -503,17 +503,26 @@ class ServerTestCase(unittest.TestCase):
self.assertEqual(len(recipes), 1)
self.assertEqual(recipes[0], test_recipe)
def assert_documentation(self, response):
"""
Assert response containing documentation from /api/doc/ is
valid *without* comparing to the actual file on disk.
"""
self.assertEqual(200, response.status_code)
self.assertTrue(len(response.data) > 1024)
# look for some well known strings inside the documentation
self.assertRegexpMatches(response.data, "Lorax [\d.]+ documentation")
self.assertRegexpMatches(response.data, "Copyright \d+, Red Hat, Inc.")
def test_api_docs(self):
"""Test the /api/docs/"""
resp = self.server.get("/api/docs/")
doc_str = open(os.path.abspath(joinpaths(os.path.dirname(__file__), "../../docs/html/index.html"))).read()
self.assertEqual(doc_str, resp.data)
self.assert_documentation(resp)
def test_api_docs_with_existing_path(self):
"""Test the /api/docs/modules.html"""
resp = self.server.get("/api/docs/modules.html")
doc_str = open(os.path.abspath(joinpaths(os.path.dirname(__file__), "../../docs/html/modules.html"))).read()
self.assertEqual(doc_str, resp.data)
self.assert_documentation(resp)
def wait_for_status(self, uuid, wait_status):
"""Helper function that waits for a status