7cee5f9d41
The DiskBuilder class is able to build a disk its corresponding format and the installation image to install this disk by using the InstallImageBuilder. However all three tasks were handled in a row which lead to the problem that resources like active mount processes were still open when e.g the disk format is created. The race conditions produced here lead to an undefined state of the resulting disk format and/or install image. In order to avoid this the DiskBuilder class has been refactored in a way that each tasks is an atomic operation which is freeing its resources after success
118 lines
4.3 KiB
Python
118 lines
4.3 KiB
Python
|
|
from mock import patch
|
|
from mock import call
|
|
import mock
|
|
|
|
from .test_helper import *
|
|
|
|
from kiwi.exceptions import *
|
|
from kiwi.boot.image.base import BootImageBase
|
|
|
|
|
|
class TestBootImageBase(object):
|
|
@patch('kiwi.boot.image.base.mkdtemp')
|
|
@patch('kiwi.boot.image.base.os.path.exists')
|
|
@patch('platform.machine')
|
|
def setup(self, mock_machine, mock_exists, mock_mkdtemp):
|
|
mock_machine.return_value = 'x86_64'
|
|
self.boot_xml_state = mock.Mock()
|
|
self.xml_state = mock.Mock()
|
|
self.xml_state.xml_data.get_name = mock.Mock(
|
|
return_value='some-image'
|
|
)
|
|
self.xml_state.get_image_version = mock.Mock(
|
|
return_value='1.2.3'
|
|
)
|
|
self.xml_state.build_type.get_boot = mock.Mock(
|
|
return_value='oemboot/suse-13.2'
|
|
)
|
|
mock_mkdtemp.return_value = 'boot-root-directory'
|
|
mock_exists.return_value = True
|
|
self.boot_image = BootImageBase(
|
|
self.xml_state, 'some-target-dir'
|
|
)
|
|
mock_mkdtemp.assert_called_once_with(
|
|
prefix='kiwi_boot_root.', dir='some-target-dir'
|
|
)
|
|
|
|
@raises(KiwiTargetDirectoryNotFound)
|
|
def test_boot_image_raises(self):
|
|
BootImageBase(
|
|
self.xml_state, 'target-dir-does-not-exist', 'some-root-dir'
|
|
)
|
|
|
|
@raises(NotImplementedError)
|
|
def test_prepare(self):
|
|
self.boot_image.prepare()
|
|
|
|
@raises(NotImplementedError)
|
|
def test_create_initrd(self):
|
|
self.boot_image.create_initrd()
|
|
|
|
@raises(KiwiBootImageDumpError)
|
|
@patch_open
|
|
@patch('pickle.dump')
|
|
def test_dump_error(self, mock_dump, mock_open):
|
|
mock_dump.side_effect = Exception
|
|
self.boot_image.dump('filename')
|
|
|
|
@patch_open
|
|
@patch('pickle.dump')
|
|
@patch('kiwi.boot.image.base.BootImageBase.disable_cleanup')
|
|
def test_dump(self, mock_disable_cleanup, mock_dump, mock_open):
|
|
context_manager_mock = mock.Mock()
|
|
mock_open.return_value = context_manager_mock
|
|
file_mock = mock.Mock()
|
|
enter_mock = mock.Mock()
|
|
exit_mock = mock.Mock()
|
|
enter_mock.return_value = file_mock
|
|
setattr(context_manager_mock, '__enter__', enter_mock)
|
|
setattr(context_manager_mock, '__exit__', exit_mock)
|
|
self.boot_image.dump('filename')
|
|
mock_open.assert_called_once_with('filename', 'wb')
|
|
mock_dump.assert_called_once_with(self.boot_image, file_mock)
|
|
mock_disable_cleanup.assert_called_once_with()
|
|
|
|
def test_disable_cleanup(self):
|
|
self.boot_image.disable_cleanup()
|
|
assert self.boot_image.call_destructor is False
|
|
|
|
def test_enable_cleanup(self):
|
|
self.boot_image.enable_cleanup()
|
|
assert self.boot_image.call_destructor is True
|
|
|
|
@patch('os.listdir')
|
|
def test_is_prepared(self, mock_listdir):
|
|
mock_listdir.return_value = True
|
|
assert self.boot_image.is_prepared() == mock_listdir.return_value
|
|
|
|
@patch('kiwi.boot.image.base.XMLState.copy_strip_sections')
|
|
def test_import_system_description_elements(self, mock_strip):
|
|
self.boot_image.import_system_description_elements()
|
|
assert self.xml_state.copy_displayname.called
|
|
assert self.xml_state.copy_name.called
|
|
assert self.xml_state.copy_repository_sections.called
|
|
assert self.xml_state.copy_drivers_sections.called
|
|
assert mock_strip.called
|
|
assert self.xml_state.copy_preferences_subsections.called
|
|
assert self.xml_state.copy_bootincluded_packages.called
|
|
assert self.xml_state.copy_bootincluded_archives.called
|
|
assert self.xml_state.copy_bootdelete_packages.called
|
|
assert self.xml_state.copy_build_type_attributes.called
|
|
assert self.xml_state.copy_systemdisk_section.called
|
|
assert self.xml_state.copy_machine_section.called
|
|
assert self.xml_state.copy_oemconfig_section.called
|
|
|
|
@patch('kiwi.defaults.Defaults.get_boot_image_description_path')
|
|
def test_get_boot_description_directory(self, boot_path):
|
|
boot_path.return_value = 'boot_path'
|
|
assert self.boot_image.get_boot_description_directory() == \
|
|
'boot_path/oemboot/suse-13.2'
|
|
|
|
@patch('kiwi.boot.image.base.Path.wipe')
|
|
@patch('os.path.exists')
|
|
def test_destructor(self, mock_path, mock_wipe):
|
|
mock_path.return_value = True
|
|
self.boot_image.__del__()
|
|
mock_wipe.assert_called_once_with('boot-root-directory')
|