7cee5f9d41
The DiskBuilder class is able to build a disk its corresponding format and the installation image to install this disk by using the InstallImageBuilder. However all three tasks were handled in a row which lead to the problem that resources like active mount processes were still open when e.g the disk format is created. The race conditions produced here lead to an undefined state of the resulting disk format and/or install image. In order to avoid this the DiskBuilder class has been refactored in a way that each tasks is an atomic operation which is freeing its resources after success
90 lines
2.7 KiB
Python
90 lines
2.7 KiB
Python
|
|
from mock import patch
|
|
|
|
import mock
|
|
|
|
from .test_helper import *
|
|
|
|
from kiwi.system.result import Result
|
|
from kiwi.exceptions import *
|
|
|
|
|
|
class TestResult(object):
|
|
def setup(self):
|
|
self.context_manager_mock = mock.MagicMock()
|
|
self.file_mock = mock.MagicMock()
|
|
self.enter_mock = mock.MagicMock()
|
|
self.exit_mock = mock.MagicMock()
|
|
self.enter_mock.return_value = self.file_mock
|
|
setattr(self.context_manager_mock, '__enter__', self.enter_mock)
|
|
setattr(self.context_manager_mock, '__exit__', self.exit_mock)
|
|
|
|
self.xml_state = mock.Mock()
|
|
|
|
self.result = Result(self.xml_state)
|
|
|
|
def test_add(self):
|
|
self.result.add('foo', 'bar')
|
|
result = self.result.get_results()
|
|
assert result['foo'].filename == 'bar'
|
|
assert result['foo'].use_for_bundle is True
|
|
assert result['foo'].compress is False
|
|
|
|
@patch('kiwi.logger.log.info')
|
|
def test_print_results_no_data(self, mock_info):
|
|
self.result.print_results()
|
|
assert mock_info.called == 0
|
|
|
|
@patch('kiwi.logger.log.info')
|
|
def test_print_results_data(self, mock_info):
|
|
self.result.add('foo', 'bar')
|
|
self.result.print_results()
|
|
assert mock_info.called
|
|
|
|
@patch('pickle.dump')
|
|
@patch_open
|
|
def test_dump(self, mock_open, mock_pickle_dump):
|
|
mock_open.return_value = self.context_manager_mock
|
|
self.result.dump('kiwi.result')
|
|
mock_open.assert_called_once_with(
|
|
'kiwi.result', 'wb'
|
|
)
|
|
mock_pickle_dump.assert_called_once_with(
|
|
self.result, self.file_mock
|
|
)
|
|
|
|
@patch('pickle.dump')
|
|
@patch_open
|
|
@raises(KiwiResultError)
|
|
def test_dump_failed(self, mock_open, mock_pickle_dump):
|
|
mock_pickle_dump.side_effect = Exception
|
|
self.result.dump('kiwi.result')
|
|
|
|
@patch('pickle.load')
|
|
@patch('os.path.exists')
|
|
@patch_open
|
|
def test_load(self, mock_open, mock_exists, mock_pickle_load):
|
|
mock_open.return_value = self.context_manager_mock
|
|
mock_exists.return_value = True
|
|
Result.load('kiwi.result')
|
|
mock_open.assert_called_once_with(
|
|
'kiwi.result', 'rb'
|
|
)
|
|
mock_pickle_load.assert_called_once_with(
|
|
self.file_mock
|
|
)
|
|
|
|
@patch('os.path.exists')
|
|
@raises(KiwiResultError)
|
|
def test_load_result_not_present(self, mock_exists):
|
|
mock_exists.return_value = False
|
|
Result.load('kiwi.result')
|
|
|
|
@patch('pickle.load')
|
|
@patch('os.path.exists')
|
|
@raises(KiwiResultError)
|
|
def test_load_failed(self, mock_exists, mock_pickle_load):
|
|
mock_exists.return_value = True
|
|
mock_pickle_load.side_effect = Exception
|
|
Result.load('kiwi.result')
|