kiwi-el8/test/unit/cli_test.py
Marcus Schäfer f05e8b905a
Fixed API vs. CLI inconsistency
when using kiwi as API the program fails with a usage message
from the Cli class. The kiwi.cli module should not be imported
except for kiwi comandline tasks. It has turned out that the
RuntimeConfig class which is used in several places in different
API classes imports Cli and creates an instance of it to check
for a global option. This causes major issues for all programs
which uses the kiwi API but not the command line interface because
the docopt call in Cli() expects a valid docstring which only
exists in kiwi's cli.py. This commit fixes the inconsistency
and allows people to use the kiwi API independent of any
command line interface. Fixes #1755
2021-03-08 10:08:26 +01:00

206 lines
6.0 KiB
Python

import sys
import logging
from mock import patch
from pytest import (
raises, fixture
)
from .test_helper import argv_kiwi_tests
from kiwi.cli import Cli
from kiwi.exceptions import (
KiwiCompatError,
KiwiLoadCommandUndefined,
KiwiCommandNotLoaded,
KiwiUnknownServiceName
)
class TestCli:
@fixture(autouse=True)
def inject_fixtures(self, caplog):
self._caplog = caplog
def setup(self):
self.expected_global_args = {
'help': False,
'--compat': False,
'compat': False,
'--type': None,
'image': False,
'system': True,
'-h': False,
'--logfile': None,
'--color-output': False,
'<legacy_args>': [],
'--version': False,
'--debug': False,
'result': False,
'--profile': [],
'--shared-cache-dir': '/var/cache/kiwi',
'--help': False,
'--config': 'config-file'
}
self.command_args = {
'--add-repo': [],
'--allow-existing-root': False,
'--description': 'description',
'--help': False,
'--ignore-repos': False,
'--ignore-repos-used-for-build': False,
'--clear-cache': False,
'--root': 'directory',
'--set-repo': None,
'--add-package': [],
'--add-bootstrap-package': [],
'--delete-package': [],
'--set-container-derived-from': None,
'--set-container-tag': None,
'--add-container-label': [],
'--signing-key': [],
'-h': False,
'help': False,
'prepare': True,
'system': True
}
self.cli = Cli()
self.loaded_command = self.cli.load_command()
def teardown(self):
sys.argv = argv_kiwi_tests
@patch('kiwi.cli.Help.show')
def test_show_and_exit_on_help_request(self, help_show):
self.cli.all_args['help'] = True
with raises(SystemExit):
self.cli.show_and_exit_on_help_request()
help_show.assert_called_once_with('kiwi')
def test_get_servicename_system(self):
cli = Cli()
assert cli.get_servicename() == 'system'
def test_get_servicename_compat_as_option(self):
sys.argv = [
sys.argv[0],
'--compat', '--',
'--build', 'description',
'--type', 'oem',
'-d', 'destination'
]
cli = Cli()
assert cli.get_servicename() == 'compat'
def test_get_servicename_compat_as_service(self):
sys.argv = [
sys.argv[0],
'compat',
'--build', 'description',
'--type', 'oem',
'-d', 'destination'
]
cli = Cli()
assert cli.get_servicename() == 'compat'
def test_warning_on_use_of_legacy_disk_type(self):
sys.argv = [
sys.argv[0],
'--type', 'vmx', 'system', 'build',
'--description', 'description',
'--target-dir', 'directory'
]
cli = Cli()
with self._caplog.at_level(logging.WARNING):
cli.get_global_args()
assert 'vmx type is now a subset of oem, --type set to oem' in \
self._caplog.text
def test_get_servicename_image(self):
sys.argv = [
sys.argv[0],
'image', 'resize',
'--target-dir', 'directory',
'--size', '20g'
]
cli = Cli()
assert cli.get_servicename() == 'image'
def test_get_servicename_result(self):
sys.argv = [
sys.argv[0],
'result', 'list',
'--target-dir', 'directory'
]
cli = Cli()
assert cli.get_servicename() == 'result'
def test_get_command(self):
assert self.cli.get_command() == 'prepare'
def test_get_command_args(self):
assert self.cli.get_command_args() == self.command_args
def test_get_global_args(self):
self.cli.all_args['--config'] = 'config-file'
sys.argv = [
sys.argv[0],
'--config', 'config-file',
'system', 'build',
'--description', 'description',
'--target-dir', 'directory'
]
cli = Cli()
assert cli.get_global_args() == self.expected_global_args
def test_load_command(self):
assert self.cli.load_command() == self.loaded_command
@patch('kiwi.cli.Cli.invoke_kiwicompat')
def test_load_command_compat_mode(self, mock_compat):
sys.argv = [
sys.argv[0],
'--compat', '--',
'--build', 'description',
'--type', 'oem',
'-d', 'destination'
]
cli = Cli()
cli.load_command()
mock_compat.assert_called_once_with(
['--build', 'description', '--type', 'oem', '-d', 'destination']
)
@patch('kiwi.cli.Path.which')
@patch('os.execvp')
def test_invoke_kiwicompat_exec_failed(self, mock_exec, mock_which):
mock_which.return_value = 'kiwicompat'
mock_exec.side_effect = Exception
with raises(KiwiCompatError):
self.cli.invoke_kiwicompat([])
def test_load_command_unknown(self):
self.cli.loaded = False
self.cli.all_args['<command>'] = 'foo'
with raises(KiwiCommandNotLoaded):
self.cli.load_command()
def test_load_command_undefined(self):
self.cli.loaded = False
self.cli.all_args['<command>'] = None
with raises(KiwiLoadCommandUndefined):
self.cli.load_command()
def test_get_command_args_not_loaded(self):
sys.argv = [
sys.argv[0], 'system', 'command-not-implemented'
]
cli = Cli()
with raises(KiwiCommandNotLoaded):
cli.get_command_args()
def test_get_servicename_unknown(self):
self.cli.all_args['system'] = False
self.cli.all_args['foo'] = False
with raises(KiwiUnknownServiceName):
self.cli.get_servicename()