The runtime check compared the given target path if it starts with the cache directory /var/cache/kiwi. This however also matches for e.g /var/cache/kiwi-foo which would be a valid target directory. This patch changes the matcher in a way to really check if the target directory points to the same cache directory structure.
100 lines
3.6 KiB
Python
100 lines
3.6 KiB
Python
from mock import patch
|
|
|
|
from .test_helper import raises
|
|
|
|
from kiwi.xml_state import XMLState
|
|
from kiwi.xml_description import XMLDescription
|
|
from kiwi.runtime_checker import RuntimeChecker
|
|
from kiwi.exceptions import KiwiRuntimeError
|
|
|
|
|
|
class TestRuntimeChecker(object):
|
|
def setup(self):
|
|
self.description = XMLDescription(
|
|
'../data/example_runtime_checker_config.xml'
|
|
)
|
|
self.xml_state = XMLState(
|
|
self.description.load()
|
|
)
|
|
self.runtime_checker = RuntimeChecker(self.xml_state)
|
|
|
|
@raises(KiwiRuntimeError)
|
|
def test_check_image_include_repos_http_resolvable(self):
|
|
self.runtime_checker.check_image_include_repos_http_resolvable()
|
|
|
|
@raises(KiwiRuntimeError)
|
|
def test_invalid_target_dir_pointing_to_shared_cache_1(self):
|
|
self.runtime_checker.check_target_directory_not_in_shared_cache(
|
|
'/var/cache//kiwi/foo'
|
|
)
|
|
|
|
@raises(KiwiRuntimeError)
|
|
def test_invalid_target_dir_pointing_to_shared_cache_2(self):
|
|
self.runtime_checker.check_target_directory_not_in_shared_cache(
|
|
'/var/cache/kiwi'
|
|
)
|
|
|
|
@raises(KiwiRuntimeError)
|
|
@patch('os.getcwd')
|
|
def test_invalid_target_dir_pointing_to_shared_cache_3(self, mock_getcwd):
|
|
mock_getcwd.return_value = '/'
|
|
self.runtime_checker.check_target_directory_not_in_shared_cache(
|
|
'var/cache/kiwi'
|
|
)
|
|
|
|
@raises(KiwiRuntimeError)
|
|
def test_invalid_target_dir_pointing_to_shared_cache_4(self):
|
|
self.runtime_checker.check_target_directory_not_in_shared_cache(
|
|
'//var/cache//kiwi/foo'
|
|
)
|
|
|
|
def test_valid_target_dir_1(self):
|
|
assert self.runtime_checker.check_target_directory_not_in_shared_cache(
|
|
'/var/cache/kiwi-fast-tmpsystemdir'
|
|
) is None
|
|
|
|
def test_valid_target_dir_2(self):
|
|
assert self.runtime_checker.check_target_directory_not_in_shared_cache(
|
|
'/foo/bar'
|
|
) is None
|
|
|
|
@raises(KiwiRuntimeError)
|
|
def test_check_repositories_configured(self):
|
|
self.xml_state.delete_repository_sections()
|
|
self.runtime_checker.check_repositories_configured()
|
|
|
|
@raises(KiwiRuntimeError)
|
|
def test_check_volume_setup_has_no_root_definition(self):
|
|
self.runtime_checker.check_volume_setup_has_no_root_definition()
|
|
|
|
@patch('kiwi.runtime_checker.Path.which')
|
|
@raises(KiwiRuntimeError)
|
|
def test_check_docker_tool_chain_installed(self, mock_which):
|
|
mock_which.return_value = False
|
|
xml_state = XMLState(
|
|
self.description.load(), ['docker'], 'docker'
|
|
)
|
|
runtime_checker = RuntimeChecker(xml_state)
|
|
runtime_checker.check_docker_tool_chain_installed()
|
|
|
|
@raises(KiwiRuntimeError)
|
|
def test_check_boot_image_reference_correctly_setup(self):
|
|
self.xml_state.build_type.set_image('vmx')
|
|
self.xml_state.build_type.set_initrd_system('dracut')
|
|
self.xml_state.build_type.set_boot('boot/some-kiwi-boot-description')
|
|
self.runtime_checker.check_boot_image_reference_correctly_setup()
|
|
|
|
@raises(KiwiRuntimeError)
|
|
@patch('platform.machine')
|
|
@patch('kiwi.runtime_checker.Defaults.get_boot_image_description_path')
|
|
def test_check_consistent_kernel_in_boot_and_system_image(
|
|
self, mock_boot_path, mock_machine
|
|
):
|
|
mock_boot_path.return_value = '../data'
|
|
mock_machine.return_value = 'x86_64'
|
|
xml_state = XMLState(
|
|
self.description.load(), ['vmxFlavour'], 'oem'
|
|
)
|
|
runtime_checker = RuntimeChecker(xml_state)
|
|
runtime_checker.check_consistent_kernel_in_boot_and_system_image()
|