Commit Graph

15 Commits

Author SHA1 Message Date
Marcus Schäfer
20b02bf683
Explain why bytes type is redefined
In python2 bytes is string which is different from the bytes
type in python3. The bytes type from the builtins generalizes
this type to be bytes always. However the redefinition of the
bytes type is marked as Smell in landscape. Thus the code
should at least inform why this is done
2016-07-25 10:52:20 +02:00
Marcus Schäfer
22c2227e28
Use six.Iterator instead of global object builtin
The use of six.Iterator as base class for the CommandIterator
seems more clear and explicit compared to the global object
type overwritten by the builtins import. Fixes Smell reported
by landscape
2016-07-25 10:43:23 +02:00
Marcus Schäfer
319fb9e6e4
Adapt to common python style
Private methods should start with _f() not __f()
2016-06-15 16:27:45 +02:00
Bo Maryniuk
80900e46c5 Bring byte strings to Py2 compatibility in ISO 2016-06-08 11:46:36 +02:00
Bo Maryniuk
6ee5981bd5 Make iterators Py2 comptible 2016-06-07 23:44:33 +02:00
Thomas Schraitle
741e3a8c04 Use iterator protocol instead of StopIteration
CommandIterator contains already the __iter__ magic method. We don't
need to manually use while and next() in order to advance to the next
element.

=> Code refactored to "for line in self.command" which does exactly the
   same job, but is better readable. Plus we avoid the nasty try...except
   block.
2016-05-01 19:18:51 +02:00
Marcus Schäfer
8e6812dcf6
Update inline API documentation 2016-04-11 15:09:26 +02:00
Marcus Schäfer
58861fdcc8 Update inline API documentation 2016-04-10 22:51:20 +02:00
Marcus Schäfer
40e6308aa9 Port application from python 2.7 to 3.4
For new applications like this kiwi version and its use cases
it is better to base it on a more recent python version
2016-02-17 22:38:38 +01:00
Marcus Schäfer
f540dc4b04
Fixed CommandIterator
check for output before sending an iteration stop
2016-02-07 18:12:31 +01:00
Marcus Schäfer
638083fb76
Prevent duplicate error logging 2016-02-03 22:32:33 +01:00
Marcus Schäfer
2e9f596c4a
Refactor CommandProcess class
Use an iterator class to run through the process. implement
poll variants explicit and clear structured
2016-02-03 22:14:52 +01:00
Marcus Schäfer
5d6fa811f5
Fixing landscape issues 2016-01-18 17:30:38 +01:00
Marcus Schäfer
61ea327a4c
Added isolinux bootloader support 2015-12-09 10:39:21 +01:00
Marcus Schäfer
09daca60c0
KIWI - appliance builder next generation
a rewrite of the current kiwi from https://github.com/openSUSE/kiwi
2015-12-05 16:17:10 +01:00