Commit Graph

4 Commits

Author SHA1 Message Date
Marcus Schäfer
7b479cbd9c
Refactor DiskFormat
This commit refactors DiskFormat to turn it into a proper
factory class and to also include type hints to facilitate it's
use from an API POV. Related to #1498
2020-11-02 14:53:36 +01:00
Marcus Schäfer
211e446f39
Fixed ovf Machine section setup for virtualbox
Required attributes/sections name, ostype, uuid and StorageControllers
were missing according to IVirtualBox::createMachine documentation
from here:

    https://www.virtualbox.org/sdkref/interface_i_virtual_box.html

This Fixes #1322
2020-04-30 13:38:20 +02:00
Marcus Schäfer
5442e9c88a
Create qcow2 images in two steps
The creation of the qcow2 format was done in one qemu-img
convert call. That call instructs qemu to compress and
convert in one call. The downside of this approach is that
not all qcow2 options can be used. For example the setup
of:

    <type ... formatoptions="preallocation=metadata"/>

failed the build with an error message that compression and
preallocation is not possible at the same time. Thus this patch
changes the way the qcow2 image is created to be done in two
steps. The first step converts the format without compression
and therefore allows for any format option to be used. The
second call only applies the compression and leads to the
final result.
2020-04-11 18:18:02 +02:00
David Cassany
4b3a105026
Re-structure unit tests folders
This commit relocates unit tests to a folder structure that matches
the source code structure.

Fixes #1128
2019-10-21 14:00:05 +02:00