Fix landscape Smells

kiwi/boot/image/base.py

@@ -92,9 +92,11 @@ class BootImageBase(object):
         """
         raise NotImplementedError
 
-    def create_initrd(self):
+    def create_initrd(self, mbrid=None):
         """
         Implements creation of the initrd
+
+        :param object mbrid: instance of ImageIdentifier
         """
         raise NotImplementedError
 

kiwi/boot/image/dracut.py

@@ -76,6 +76,8 @@ class BootImageDracut(BootImageBase):
     def create_initrd(self, mbrid=None):
         """
         Call dracut to create the initrd and XZ compress the result
+
+        :param object mbrid: unused
         """
         if self.is_prepared():
             log.info('Creating generic dracut initrd archive')

kiwi/boot/image/kiwi.py

@@ -85,6 +85,8 @@ class BootImageKiwi(BootImageBase):
     def create_initrd(self, mbrid=None):
         """
         Create initrd from prepared boot system tree and compress the result
+
+        :param object mbrid: instance of ImageIdentifier
         """
         if self.is_prepared():
             log.info('Creating initrd cpio archive')

kiwi/bootloader/config/grub2.py

@@ -508,9 +508,9 @@ class BootLoaderConfigGrub2(BootLoaderConfigBase):
                     options=['-z', '-a']
                 )
 
-        self._check_boot_theme_exists(lookup_path)
+        self._check_boot_theme_exists()
 
-    def _check_boot_theme_exists(self, lookup_path):
+    def _check_boot_theme_exists(self):
         if self.theme:
             theme_dir = os.sep.join(
                 [

kiwi/filesystem/isofs.py

@@ -25,7 +25,7 @@ class FileSystemIsoFs(FileSystemBase):
     """
     Implements creation of iso filesystem
     """
-    def create_on_file(self, filename, label=None):
+    def create_on_file(self, filename, label=None, exclude=None):
         """
         Create iso filesystem from data tree
 
@@ -34,6 +34,7 @@ class FileSystemIsoFs(FileSystemBase):
 
         :param string filename: result file path name
         :param string label: unused
+        :param string exclude: unused
         """
         iso = Iso(self.root_dir)
         iso.init_iso_creation_parameters(

kiwi/kiwi_compat.py

@@ -198,6 +198,6 @@ def main():
         # logging.info('Calling: kiwi %s', ' '.join(arguments.translated))
         Command.execute(arguments.translated)
     except NotImplementedError as e:
-        logging.error('KiwiCompatError: %s' % format(e))
+        logging.error('KiwiCompatError: %s', format(e))
     except OSError as e:
-        logging.error('KiwiCompatError: %s' % format(e))
+        logging.error('KiwiCompatError: %s', format(e))